Page MenuHomePhabricator
Create Task
Maniphest T264777

Include error message translations in the user language in the REST API's error response
Open, Needs TriagePublic
Actions

Description

The REST API's error response schema includes an object (messageTranslations), for returning key-value pairs of language code to translated error message.

The included languages, defined in EntryPoint::getTextFormatters are the content language and English. The messageTranslations object is made in ResponseFactory::formatMessage, using these languages.

It would be helpful to add the user language too, if it differs from either of these. Tagging Platform Engineering in case there's a particular reason why not to include the user language.

Related Objects

Event Timeline

Tchanders created this task.Oct 6 2020, 5:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2020, 5:16 PM
Tchanders mentioned this in T263409: Display pending element and error message on the IPInfo popup, where appropriate.Oct 6 2020, 5:18 PM
Reedy added a project: I18n.Oct 6 2020, 5:38 PM
Niharika subscribed.Oct 7 2020, 5:01 AM

@Tchanders Would this be a good contender for a new engineer onboarding task?

Tchanders added a comment.Oct 7 2020, 8:51 AM

@Niharika I think it could be, if Platform Engineering are happy for us to do this

dbarratt added a project: Platform Engineering.Oct 7 2020, 3:57 PM
Naike removed a project: Platform Engineering.Oct 13 2020, 8:32 PM
Naike subscribed.

@Tchanders we're thrilled for you to do this task! Thank you for offering.

Niharika added a project: Anti-Harassment.Oct 13 2020, 9:13 PM

Adding this to our board. If it seems like it's not a good fit for our team, we may place it up for grabs later. :)

Tgr mentioned this in T269492: Selecting user language in the REST API.Dec 5 2020, 5:09 AM
Daimona subscribed.Apr 7 2022, 4:10 PM
BPirkle mentioned this in T311423: Provide a convenient way to obtain localized error messages in the JS REST API framework.Aug 31 2022, 2:52 PM
TAdeleye_WMF edited projects, added Trust and Safety Product Team; removed Anti-Harassment.Tue, May 14, 4:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL