Defer DOM lookups until necessary in IP Info
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Nov 4 2020, 4:59 PM

Description

As a performance improvement, make sure more complex actions like initiating OOUI widgets and DOM node lookups are only performed if necessary (i.e. no early returns) - from T260821#6600060.

In this example, complex objects are initialized then thrown away if the method returns early. We should refactor this to ensure these objects are only made when they are needed.

Details

	Subject	Repo	Branch	Lines +/-
	Refactor when DOM-dependent variable values are assigned in IPInfo init	mediawiki/extensions/IPInfo	master	+13 -12

Customize query in gerrit

Related Objects

Mentioned In: rEIPIe48a0c2c5b3d: Refactor when DOM-dependent variable values are assigned in IPInfo init
T260821: Performance review of IP Info extension
Mentioned Here: T260821: Performance review of IP Info extension

Event Timeline

Tchanders created this task.Nov 4 2020, 4:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2020, 4:59 PM

Tchanders mentioned this in T260821: Performance review of IP Info extension.Nov 4 2020, 5:01 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Nov 4 2020, 5:04 PM

ARamirez_WMF set the point value for this task to 2.Nov 4 2020, 5:19 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

• Gilles subscribed.Nov 5 2020, 1:05 PM

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Nov 5 2020, 6:18 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

STran claimed this task.Nov 17 2020, 7:45 PM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Tchanders updated the task description. (Show Details)Nov 17 2020, 8:14 PM

Change 641583 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/IPInfo@master] Refactor when DOM-dependent variable values are assigned in IPInfo init

https://gerrit.wikimedia.org/r/641583

gerritbot added a project: Patch-For-Review.Nov 18 2020, 2:22 AM

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Nov 18 2020, 8:16 PM

Change 641583 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Refactor when DOM-dependent variable values are assigned in IPInfo init

https://gerrit.wikimedia.org/r/641583

Bypassing QA since this was a small refactor and was tested in code review

STran mentioned this in rEIPIe48a0c2c5b3d: Refactor when DOM-dependent variable values are assigned in IPInfo init.Nov 18 2020, 8:32 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2020, 9:10 PM

Niharika closed this task as Resolved.Nov 20 2020, 5:56 PM

Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:59 PM

Defer DOM lookups until necessary in IP InfoClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Defer DOM lookups until necessary in IP Info
Closed, ResolvedPublic2 Estimated Story Points
Actions