Page MenuHomePhabricator
Create Task
Maniphest T267822

Fix jsduck warnings in Wikispeech
Closed, ResolvedPublic
Actions

Description

Running jsduck on the Wikispeech direcotry (using composer doc) results in the following warnings

Warning: /vagrant/mediawiki/extensions/Wikispeech/modules/ext.wikispeech.loader.js:3: Unnamed property
Warning: /vagrant/mediawiki/extensions/Wikispeech/jsduck-categories.json Class 'global' not found in categories file
Warning: /vagrant/mediawiki/extensions/Wikispeech/modules/ext.wikispeech.ui.js:97: Unknown type OO.ui.ButtonGroupWidget
Warning: /vagrant/mediawiki/extensions/Wikispeech/modules/ext.wikispeech.ui.js:97: Unknown type OO.ui.ButtonWidget
Warning: /vagrant/mediawiki/extensions/Wikispeech/modules/ext.wikispeech.ui.js:205: Unknown type OO.ui.ButtonGroupWidget
Warning: /vagrant/mediawiki/extensions/Wikispeech/modules/ext.wikispeech.storage.js:170: Unknown type jQuery.Promise

Details

SubjectRepoBranchLines +/-
Fix jsduck warningmediawiki/extensions/Wikispeechmaster+3 -1
Fix jsduck Unknown type warningsmediawiki/extensions/Wikispeechmaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Lokal_Profil created this task.Nov 13 2020, 8:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2020, 8:53 AM
Lokal_Profil added a comment.Nov 13 2020, 8:54 AM

On vagrant jsduck must first be installed using sudo gem install jsduck

Lokal_Profil moved this task from Unsorted to Code hygiene and deployment requirements [MW Extension] on the Wikispeech-Text-to-Speech board.Nov 13 2020, 8:54 AM
Lokal_Profil added a project: Wikispeech-WMSE.Nov 13 2020, 8:57 AM
Lokal_Profil added a comment.Nov 13 2020, 9:19 AM

adding OO.ui.* and jQuery.Promise to --external in jsduck.json should fix most of these. Unsure about the first though.

In general we should be aware of T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases

gerritbot added a comment.Nov 13 2020, 9:23 AM

Change 640922 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[mediawiki/extensions/Wikispeech@master] Fix jsduck warnings

https://gerrit.wikimedia.org/r/640922

gerritbot added a project: Patch-For-Review.Nov 13 2020, 9:23 AM
Lokal_Profil added a comment.Nov 13 2020, 9:24 AM

Class 'global' not found in categories file is caused by the issue with ext.wikispeech.loader.js:3

Lokal_Profil added projects: User-LokalProfil, User-Sebastian_Berlin-WMSE.Nov 17 2020, 9:07 AM
Lokal_Profil moved this task from Backlog to Reviewing on the User-Sebastian_Berlin-WMSE board.
gerritbot added a comment.Nov 17 2020, 9:11 AM

Change 641388 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[mediawiki/extensions/Wikispeech@master] Fix jsduck warning

https://gerrit.wikimedia.org/r/641388

Lokal_Profil moved this task from 📥 Backlog to ⏳ Waiting on the User-LokalProfil board.Nov 17 2020, 12:32 PM
gerritbot added a comment.Nov 18 2020, 9:09 AM

Change 640922 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Fix jsduck Unknown type warnings

https://gerrit.wikimedia.org/r/640922

Lokal_Profil mentioned this in rEWIS456c2840c1f2: Fix jsduck Unknown type warnings.Nov 18 2020, 9:10 AM
gerritbot added a comment.Nov 25 2020, 3:07 PM

Change 641388 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Fix jsduck warning

https://gerrit.wikimedia.org/r/641388

Maintenance_bot removed a project: Patch-For-Review.Nov 25 2020, 3:10 PM
Lokal_Profil mentioned this in rEWISe6f74930bea7: Fix jsduck warning.Nov 25 2020, 3:12 PM
Sebastian_Berlin-WMSE moved this task from Reviewing to Done on the User-Sebastian_Berlin-WMSE board.Nov 25 2020, 3:40 PM
Sebastian_Berlin-WMSE edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.
Sebastian_Berlin-WMSE moved this task from Backlog to Done on the Wikispeech-Jobrunner (Sprint) board.
Lokal_Profil claimed this task.Dec 3 2020, 8:41 AM
Lokal_Profil closed this task as Resolved.Dec 3 2020, 12:05 PM
Jopparn moved this task from ⏳ Waiting to ☑️ Done on the User-LokalProfil board.Jan 24 2021, 10:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL