Page MenuHomePhabricator

CookieWarning does not work with MinervaNeue theme: <div id="siteNotice"> is empty (due to wgMinervaEnableSiteNotice disabled)
Closed, InvalidPublic

Description

After the latest Update which is documented in T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook the Cookie Warning extension does work with the Vector skin again, but not with the MinervaNeue Skin.

I use MediaWiki 1.35 with the latest git clone of Branch REL1_35.
Setup is here

I hope it is not only a configuration issue, but with MediaWiki 1.34 everything worked fine. And even with 1.35 and the not fixed Vector Version of Cookie Warning, the minerva worked, too.

best regards
Andreas

Event Timeline

Aklapper renamed this task from Did not work anymore with the MinervaNeue Mobile Theme to CookieWarning does not work anymore with the MinervaNeue theme.Dec 3 2020, 7:48 PM
Aklapper updated the task description. (Show Details)

Hi @Alaub81, thanks for taking the time to report this! What does "does not work" mean exactly?
Not displayed? Something else? Please see and follow https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks a lot!

Hi @Aklapper , sorry for that :-)

The Cookie Warning message is not displayed, even with a new private tab in my browser. If I switch with the mobile view / desktop view button, and the desktop view is shown, the message is there.

you can test it on my wiki installation right here: https://www.laub-home.de

If you need more informations, feel free to ask me.

cheers
Andreas

Aklapper renamed this task from CookieWarning does not work anymore with the MinervaNeue theme to CookieWarning does not work anymore with MinervaNeue theme: <div id="siteNotice"> is empty.Dec 3 2020, 8:02 PM

Just to be sure, wgMinervaEnableSiteNotice is enabled?

Shame on me... with that Option in the LocalSettings.php it is shown up again.

$wgMinervaEnableSiteNotice = true;

Thank you @Aklapper

I think that ticket could be closed.

Aklapper renamed this task from CookieWarning does not work anymore with MinervaNeue theme: <div id="siteNotice"> is empty to CookieWarning does not work with MinervaNeue theme: <div id="siteNotice"> is empty (due to wgMinervaEnableSiteNotice disabled).Dec 4 2020, 10:35 AM

No problem, glad you found the reason :)

Just for reference: With change rSMIN557529546e4a: Change default of showing sitenotices to true, this is now the default, so you, @Alaub81, can maybe remove this setting from your LocalSettings.php for a cleaner configuration.

@Florian I just updated everything and it does not work without the parameter. I checked the Ticket and saw. It is only released to the master and 1.36 branch. So I am using the 1.35 branch for the skin. So I have to wait a bit :-)

But thanks for the great information!