Page MenuHomePhabricator
Create Task
Maniphest T271213

Edit Count doesn't retroactively update after adjusting $wgNamespacesForEditPoints
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Adjust $wgNamespacesForEditPoints to include more namespaces: $wgNamespacesForEditPoints = [ 0, 2, 4, 6, 8, 10 ];
  2. Go to Special:UpdateEditCounts
  3. See user's edit count on their profile

Actual Results:
Edit count doesn't change to include previous edits. Still shows the edit count from the main namespace but starts counting edits in these other namespaces from now on.

Expected results:
Update the edit count to include previous edits from namespaces listed in $wgNamespacesForEditPoints.

For example, if a user has 300 main namespace edits and 200 template edits, and the template namespace is added to $wgNamespacesForEditPoints afterwards, the edit count should update to show 500 edits instead of only 300.

Details

SubjectRepoBranchLines +/-
UpdateEditCounts: Fix condition from $wgNamespacesForEditPointsmediawiki/extensions/SocialProfilemaster+1 -3
Customize query in gerrit

Related Objects

Event Timeline

Vishkujo created this task.Jan 5 2021, 4:43 PM
Restricted Application added a project: Social-Tools. · View Herald TranscriptJan 5 2021, 4:43 PM
ashley moved this task from Backlog to SocialProfile on the Social-Tools board.May 15 2021, 2:10 PM
gerritbot added a comment.Jul 5 2023, 6:39 PM

Change 935796 had a related patch set uploaded (by Martineznovo; author: Martineznovo):

[mediawiki/extensions/SocialProfile@master] UpdateEditCounts: Fix condition from $wgNamespacesForEditPoints

https://gerrit.wikimedia.org/r/935796

gerritbot added a project: Patch-For-Review.Jul 5 2023, 6:39 PM
Ciencia_Al_Poder changed the task status from Open to In Progress.Jul 5 2023, 6:39 PM
Ciencia_Al_Poder claimed this task.
Ciencia_Al_Poder added a comment.Jul 5 2023, 6:45 PM

When fixing this, debugging the resulting SQL query, I noticed something strange. The default value as defined in extension.json is [ 0 ]. If I set $wgNamespacesForEditPoints = [ 0, 6, 10, 14 ], the resulting query results in [ 0, 0, 6, 10, 14 ] (notice how the value 0 is repeated)

However, there's nothing in the code adding the extra value. If I edit the extension.json file and remove the default value, leaving it into an empty array, the extra 0 disappears.

This looks like the default behavior in the merge_strategy. This means the main namespace can't be excluded. It's a bit shocking. However I doubt anybody wants to exclude main namespace edits from being counted, so I guess it doesn't cause any harm...

gerritbot added a comment.Jul 9 2023, 9:04 PM

Change 935796 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] UpdateEditCounts: Fix condition from $wgNamespacesForEditPoints

https://gerrit.wikimedia.org/r/935796

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2023, 9:10 PM
Ciencia_Al_Poder mentioned this in rESPR767d0676b4f9: UpdateEditCounts: Fix condition from $wgNamespacesForEditPoints.Jul 9 2023, 9:17 PM
Ciencia_Al_Poder closed this task as Resolved.Jul 9 2023, 9:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL