Description

In T264355 we integrated WVUI into Vector, but it depends on the existence of WVUI in core. This in itself is blocked on the security review in T257579.

Acceptance criteria

Security gives the all clear on merging WVUI into core. Web team has taken care of any outcomes of the security review
The https://gerrit.wikimedia.org/r/c/mediawiki/core/+/641052 patch is merged
Vector is updated to remove the conditional registration of the module that depends on WVUI (https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/f6e790b11864532ce2ae2839fd588e7e99c9ef8f/includes/Hooks.php#352). The definition should be moved to skin.json
Core is using the very latest commit from WVUI

Details

	Subject	Repo	Branch	Lines +/-
	Add WVUI (0.1.0)	mediawiki/core	master	+3 K -0

Customize query in gerrit

Related Objects

Mentioned In: T275914: Using WVUI via ResourceLoader should expose icons
T259216: Migrate Special:GlobalWatchlist to Vue
T261647: Set up A/B test for new search widget
T264355: Integrate wvui-search-form into Vector
Mentioned Here: T257579: Security Readiness Review For WVUI and Vector dependencies needed for Vue.js search
T264355: Integrate wvui-search-form into Vector

Event Timeline

Jdlrobson created this task.Jan 6 2021, 6:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2021, 6:24 PM

Change 641052 had a related patch set uploaded (by Jdlrobson; owner: Catrope):
[mediawiki/core@master] Add wvui (0.0.2-next.2020-12-09-21-05.0)

https://gerrit.wikimedia.org/r/641052

gerritbot added a project: Patch-For-Review.Jan 6 2021, 6:25 PM

Jdlrobson mentioned this in T264355: Integrate wvui-search-form into Vector.Jan 6 2021, 6:25 PM

ovasileva triaged this task as High priority.Jan 11 2021, 4:25 PM

Volker_E updated the task description. (Show Details)Jan 13 2021, 5:37 PM

No analysis can be done here, until we get the results of the security review.

• nray updated the task description. (Show Details)Jan 27 2021, 5:46 PM

• nray updated the task description. (Show Details)Jan 27 2021, 7:00 PM

Change 641052 had a related patch set uploaded (by Nray; owner: Catrope):
[mediawiki/core@master] Add wvui (0.0.2-next.2020-12-09-21-05.0)

https://gerrit.wikimedia.org/r/641052

phuedx mentioned this in T261647: Set up A/B test for new search widget.Jan 29 2021, 3:54 PM

DannyS712 mentioned this in T259216: Migrate Special:GlobalWatchlist to Vue.Feb 1 2021, 5:18 PM

Change 641052 had a related patch set uploaded (by Jdlrobson; owner: Catrope):
[mediawiki/core@master] Add WVUI (0.0.2-next.2021-01-11-22-44.0)

https://gerrit.wikimedia.org/r/641052

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 12 2021, 2:01 AM

Change 641052 merged by jenkins-bot:
[mediawiki/core@master] Add WVUI (0.1.0)

https://gerrit.wikimedia.org/r/641052

Fairly sure this can be closed as resolved now, but leaving for readers web team to sign off

DannyS712 added a project: WVUI.Feb 12 2021, 2:48 AM

Jdlrobson reassigned this task from Jdlrobson to Volker_E.Feb 18 2021, 6:05 PM

Successfully resolved! 🎉

DannyS712 mentioned this in T275914: Using WVUI via ResourceLoader should expose icons.Feb 26 2021, 8:37 PM

Add WVUI as a vendor library in coreClosed, ResolvedPublicActions

Description

Acceptance criteria

Details

Related Objects

Event Timeline

Add WVUI as a vendor library in core
Closed, ResolvedPublic
Actions