ve.dm.Surface#setNullSelection should not clear a native selection that is outside of the document
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dchan
	Jan 16 2021, 3:01 PM

Description

Steps to reproduce:

Open VE standalone
Programmatically set the selection to somewhere outside the VE surface, then call ve.dm.Surface#setNullSelection

Expected behaviour:
The selection is untouched (because a native selection outside the VE surface is already effectively a null selection from VE's point of view)

Actual behaviour
The selection is cleared

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (c7ecbcb39)	mediawiki/extensions/VisualEditor	master	+1 -1
	setNullSelection: don't clear a selection outside the surface	VisualEditor/VisualEditor	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned Here: rGVEDc7ecbcb39583: Merge "Cache offset keys used in adjustmentTree's adjustmentNodes"

Event Timeline

dchan created this task.Jan 16 2021, 3:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2021, 3:01 PM

Change 656569 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] setNullSelection: don't clear a selection outside the surface

https://gerrit.wikimedia.org/r/656569

gerritbot added a project: Patch-For-Review.Jan 16 2021, 3:03 PM

Change 656569 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] setNullSelection: don't clear a selection outside the surface

https://gerrit.wikimedia.org/r/656569

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2021, 5:10 PM

matmarex closed this task as Resolved.Jan 18 2021, 5:25 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 18 2021, 5:25 PM

Change 656978 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c7ecbcb39)

https://gerrit.wikimedia.org/r/656978

gerritbot added a project: Patch-For-Review.Jan 19 2021, 12:09 AM

Change 656978 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c7ecbcb39)

https://gerrit.wikimedia.org/r/656978

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 19 2021, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2021, 1:10 AM

ve.dm.Surface#setNullSelection should not clear a native selection that is outside of the documentClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

ve.dm.Surface#setNullSelection should not clear a native selection that is outside of the document
Closed, ResolvedPublic
Actions