Discussion Tools causes TemplateStyles to be empty in certain cases on pages without section headings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Feb 22 2021, 9:39 PM

Description

Discussion Tools causes TemplateStyles to be empty in certain cases on pages without section headings. As a result, some templates don't appear correctly.

Splitting off from T270009.

Example affected page: https://nl.wikipedia.org/wiki/Overleg_gebruiker:Thomas~nlwiki

Expected rendering should look like on this page: https://nl.wikipedia.org/wiki/Overleg_gebruiker:FQuist

In T270009#6844992, @Bdijkstra wrote:

16, 17

Re-opened, it seems that a regression happened. Same symptom on some user pages: link 16 above looks fine to me, but not link 17.

In T270009#6846145, @Tacsipacsi wrote:

Also noticed on huwiki: Szerkesztővita:Merkl.otto and Szerkesztővita:Merkl, on both pages the In memoriam… ({{gyász}}) template lacks styling.

Details

	Subject	Repo	Branch	Lines +/-
	CommentFormatter: Fix inserting placeholder heading marker	mediawiki/extensions/DiscussionTools	master	+30 -3

Customize query in gerrit

Related Objects

Mentioned In: T267404: Add reply links to the parser cache
T270009: Discussion Tools causes TemplateStyles to be empty in certain cases
Mentioned Here: T267404: Add reply links to the parser cache
T270009: Discussion Tools causes TemplateStyles to be empty in certain cases

Event Timeline

matmarex created this task.Feb 22 2021, 9:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2021, 9:39 PM

matmarex claimed this task.Feb 22 2021, 9:40 PM

matmarex mentioned this in T270009: Discussion Tools causes TemplateStyles to be empty in certain cases.

matmarex added a project: Editing-team (Kanban Board).

Mbch331 subscribed.Feb 22 2021, 10:04 PM

Change 666215 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] CommentFormatter: Fix inserting placeholder heading marker

https://gerrit.wikimedia.org/r/666215

gerritbot added a project: Patch-For-Review.Feb 22 2021, 10:06 PM

This is caused by the changes from T267404: Add reply links to the parser cache.

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Feb 22 2021, 10:08 PM