Page MenuHomePhabricator

As loading spinner is always visible, border flashes when graph height is narrow (less than 47px)
Closed, ResolvedPublic

Assigned To
Authored By
Sunpriat2
Feb 26 2021, 11:06 PM
Referenced Files
F34525005: Screenshot from 2021-06-24 18-14-30.png
Jun 24 2021, 8:55 AM
F34124330: Screenshot_2021-02-27 2.png
Feb 26 2021, 11:06 PM
F34124335: ajax-loader.gif
Feb 26 2021, 11:06 PM
F34124306: Screenshot_2021-02-27.png
Feb 26 2021, 11:06 PM
Tokens
"Doubloon" token, awarded by Yair_rand.

Description

When a small graph is drawn, for example several marks horizontally, a spinning spinner is visible at the edges.
.mw-graph has this: background-image: url (/w/extensions/Graph/includes/ajax-loader.gif?b3af8); and border: 1px solid transparent;
When there is something short on the graph and #tag:graph has "height": less than 47, then inside this border which is transparent is visible loader.gif and border flashes with gif animation

Screenshot_2021-02-27.png (33×85 px, 1 KB)

one mark and spinner flashes inside the border around the mark
Screenshot_2021-02-27 2.png (73×81 px, 1 KB)

"height":40 and the top and bottom of the spinner remains
ajax-loader.gif (64×64 px, 2 KB)

the spinner itself
This is not visible in Special: GraphSandbox since there is no .mw-graph but visible in pages and in Special: ExpandTemplates. Spinner was definitely not visible in 2018.
.mw-graph {background-clip: padding-box;} (or content-box) can fix border or border can be replaced with margin/padding

Event Timeline

Aklapper renamed this task from Spinner is always visible when the graph is narrow to As loading spinner is always visible, border flashes when graph height is narrow (less than 47px).Mar 1 2021, 7:00 AM
Jdlrobson claimed this task.
Jdlrobson moved this task from Backlog to Vega Update Phase 1 on the MediaWiki-extensions-Graph board.
Jdlrobson subscribed.

Should be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Graph/+/911356. Please let me know if there's more to do here.