PageArchiver.maxsize should be defined before calling PageArchiver.load_config()
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	4shadoww
	Mar 16 2021, 3:55 PM

Description

This change rPWBC57a0f00827cedea37c35f2f63860ea2cbba5e943 seems to cause this error on every page:

ERROR: Error occurred while processing page [[fi:Keskustelu käyttäjästä:4shadoww]]
ERROR: AttributeError: 'PageArchiver' object has no attribute 'maxsize'
Traceback (most recent call last):
  File "/data/project/thanatos/pywikibot-core/scripts/archivebot.py", line 897, in main
    archiver = PageArchiver(pg, tmpl, salt, force)
  File "/data/project/thanatos/pywikibot-core/scripts/archivebot.py", line 528, in __init__
    self.load_config()
  File "/data/project/thanatos/pywikibot-core/scripts/archivebot.py", line 593, in load_config
    self.set_attr(item.strip(), value.strip())
  File "/data/project/thanatos/pywikibot-core/scripts/archivebot.py", line 557, in set_attr
    if size > self.maxsize:
AttributeError: 'PageArchiver' object has no attribute 'maxsize'Processing [[fi:Keskustelu käyttäjästä:4shadowwBOT]]

Changing maxsize variable to be defined before calling load_config() in __init__() seems to fix this problem.

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] PageArchiver.maxsize must be defined before load_config()	pywikibot/core	master	+8 -7

Customize query in gerrit

Related Objects

Mentioned In: rPWBC627c13c13763: [bugfix] PageArchiver.maxsize must be defined before load_config()
Mentioned Here: rPWBC57a0f00827ce: [IMPR] Always take 'maxarticlesize' into account when saving

Event Timeline

4shadoww created this task.Mar 16 2021, 3:55 PM

Restricted Application added a project: Pywikibot. · View Herald TranscriptMar 16 2021, 3:55 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript

JJMC89 changed the subtype of this task from "Task" to "Bug Report".Mar 16 2021, 4:41 PM

JJMC89 added a parent task: T269066: Pywikibot release 6.0 dependencies.Mar 16 2021, 4:50 PM

4shadoww renamed this task from PageArchiver.maxsize should be defined before calling Page.Archiver.load_config() to PageArchiver.maxsize should be defined before calling PageArchiver.load_config().Mar 16 2021, 8:01 PM

JJMC89 removed a parent task: T269066: Pywikibot release 6.0 dependencies.Mar 17 2021, 12:59 AM

Xqt triaged this task as High priority.Mar 17 2021, 8:11 AM

Change 673020 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] PageArchiver.maxsize must be defined before load_config()

https://gerrit.wikimedia.org/r/673020

gerritbot added a project: Patch-For-Review.Mar 17 2021, 2:00 PM

Xqt claimed this task.Mar 17 2021, 2:00 PM

JJMC89 closed this task as Resolved.Mar 17 2021, 9:55 PM

JJMC89 removed a project: Patch-For-Review.

Change 673020 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] PageArchiver.maxsize must be defined before load_config()

https://gerrit.wikimedia.org/r/673020

Xqt mentioned this in rPWBC627c13c13763: [bugfix] PageArchiver.maxsize must be defined before load_config().Mar 17 2021, 9:58 PM