Per the linked/parent-task ticket, all Apps options are currently set to off by default. The result of this is that the user must take an additional step to receive messages in the apps. The apps already require a notification opt in, as do the mobile OSes, so there is already a standard "opt in" process that users will have to go through. So we'd like to change the default state of Apps to match the default state for Web.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Push: Make default notification options mirror web if push is enabled | mediawiki/extensions/Echo | master | +14 -1 |
Related Objects
Related Objects
- Mentioned In
- T291128: Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'arbcom_dewiki.echo_push_subscription' doesn't exist (db1175)Function: EchoPush\SubscriptionManager::getSubscriptionsForUserQuery: SELECT * FROM `echo_push_subscription` INNER JOIN `echo_push_provider` ON ((eps_provider = epp_id)) LEFT JOIN `echo_push_topic` ON ((eps_topic = ept_id)) WHERE eps_user = 91
- Mentioned Here
- T287909: Notifications API module should not hard-code the `web` notifier type
Event Timeline
Comment Actions
I'm going to tag Prod Infra with this, and add @dr0ptp4kt as EM. I'm not really officially supporting this stuff anymore, just trying to help out.
Comment Actions
Just some comments on this from the Android side:
We would second the idea of changing the defaults to enabling Apps notifications, or at least making them 1:1 with Web notifications, especially if it means that this will be necessary for getting notifications from foreign wikis via the API (with the hard-coded web parameter issue resolved). It's been vitally important for us to be able to get notifications from all wikis (notwikis=*) without any server-side setup, and it would be a shame if that went away.
And regarding push notifications, i.e. notifications that appear at the system level outside the app, the norms on Android are quite permissive, and are basically opt-in by default:
If a user (1) installs the app, and (2) logs in to their account, then receiving notifications related to their account would be entirely in line with expectations. The system then provides the user with ways of reducing or disabling notifications if they choose to. This would also align with community concerns about being unable to reach certain editors in the case of reverts or warnings on Talk pages.
Comment Actions
OK, I finally figured out why we're seeing these default discrepancies. The web preferences are being enabled in a hook handler: https://github.com/wikimedia/mediawiki-extensions-Echo/blob/15c72fe4ed1f071af8524a10508f182c5dc48702/includes/EchoHooks.php#L22-L75. I should have known. This should be easy enough to fix.
Comment Actions
Change 713708 had a related patch set uploaded (by Mholloway; author: Michael Holloway):
[mediawiki/extensions/Echo@master] Push: Make defaults mirror web if push is enabled
Comment Actions
Change 713708 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Push: Make default notification options mirror web if push is enabled
Comment Actions
@MSantos Looks good, we'll let you know if we run into any issues as we get further in development. Thanks!