Page MenuHomePhabricator
Create Task
Maniphest T291287

Watchlist expiry is not retained when clicking "show changes", but works on "show preview"
Closed, ResolvedPublic
Actions

Description

Reported at https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1044898015#Watchlist_time_period_bug_in_edit_mode?

If you change the time period to watch a page, and then click "show preview" it will retain that change for the next view so when you save it uses the expiry that was just set. However, that does not work for "show changes".

It's a trivial fix, I'll have a patch up in a moment.

Details

SubjectRepoBranchLines +/-
EditPage: Read from wpWatchlistExpiry form value on "show changes" toomediawiki/coreREL1_37+1 -1
EditPage: Read from wpWatchlistExpiry form value on "show changes" toomediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Sep 17 2021, 6:10 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 17 2021, 6:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Sep 17 2021, 6:12 PM

Change 721877 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@master] EditPage: Read from wpWatchlistExpiry form value on \"show changes\" too

https://gerrit.wikimedia.org/r/721877

gerritbot added a project: Patch-For-Review.Sep 17 2021, 6:12 PM
gerritbot added a comment.Sep 17 2021, 11:54 PM

Change 721877 merged by jenkins-bot:

[mediawiki/core@master] EditPage: Read from wpWatchlistExpiry form value on \"show changes\" too

https://gerrit.wikimedia.org/r/721877

Legoktm closed this task as Resolved.Sep 17 2021, 11:56 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 18 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 18 2021, 12:10 AM
gerritbot added a comment.Sep 20 2021, 5:13 PM

Change 722398 had a related patch set uploaded (by Jforrester; author: Legoktm):

[mediawiki/core@REL1_37] EditPage: Read from wpWatchlistExpiry form value on \"show changes\" too

https://gerrit.wikimedia.org/r/722398

gerritbot added a project: Patch-For-Review.Sep 20 2021, 5:13 PM
gerritbot added a comment.Sep 20 2021, 5:26 PM

Change 722398 merged by jenkins-bot:

[mediawiki/core@REL1_37] EditPage: Read from wpWatchlistExpiry form value on \"show changes\" too

https://gerrit.wikimedia.org/r/722398

ReleaseTaggerBot added a project: MW-1.37-notes.Sep 20 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 20 2021, 6:10 PM
thiemowmde mentioned this in T274658: Watchlist expiration time is not set correctly if an edit conflict happens.Sep 13 2023, 7:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL