Page MenuHomePhabricator
Create Task
Maniphest T293665

User page link is red in diff and history pages edit summary despite global user page existing
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce:

What happens?:
My global user page link looks red instead of blue. Also clicking the link, opens the local user page creation page instead of my user page.

What should have happened instead?:
I have a user page on meta so, it should be blue.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

image.png (693×1 px, 145 KB)
image.png (693×1 px, 703 KB)

Details

SubjectRepoBranchLines +/-
CommentParser: Optimise operation order (cache before isAlwaysKnown)mediawiki/coremaster+2 -2
CommentParser: Treat known titles as always known for linkingmediawiki/coremaster+25 -1
Customize query in gerrit

Related Objects

Event Timeline

TmY_e12 created this task.Oct 18 2021, 4:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2021, 4:24 PM
TmY_e12 updated the task description. (Show Details)Oct 18 2021, 4:24 PM
Legoktm added a project: GlobalUserPage.Oct 18 2021, 4:28 PM
Legoktm removed a subscriber: GlobalUserPage.
Aklapper added a comment.Oct 18 2021, 6:21 PM

I'm probably wrong here but I wonder if T292905, T292834, T288402 could all be vaguely related.

Legoktm subscribed.Oct 18 2021, 6:23 PM

I have yet to investigate, but at a glance this seems more like the issue described at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Redlink_to_existing_page and a potential CommentFormatter regression.

Aklapper added a comment.Oct 19 2021, 6:59 AM

Is T293707: Link to soft redirect in edit summary in page history is red a duplicate?

Tol subscribed.Oct 19 2021, 5:34 PM

@Aklapper: I think they're at least related. In T293707, it's only in the page history, but not in diffs, and with a locally created page (a soft redirect). Here, it's in diffs, and it's with a global user page, not one that's locally created.

Xaosflux mentioned this in T294027: Username appearing as redlink in history, even when page exists locally.Oct 21 2021, 2:49 PM
Tol unsubscribed.Oct 22 2021, 4:33 AM
Tol subscribed.
Krinkle subscribed.Nov 11 2021, 7:14 PM
Tol added a project: Regression.Nov 21 2021, 4:30 AM

I've seen this happening too; it was previously fine.

Tgr renamed this task from My global user page link looks red instead of blue to User page link is red in edit summary despite global user page existing.Jan 25 2022, 7:02 PM
Tgr mentioned this in T297192: Redlinked username in page history edit summaries despite a global user page existing.
Tgr renamed this task from User page link is red in edit summary despite global user page existing to User page link is red in diff page edit summary despite global user page existing.Jan 25 2022, 7:06 PM
Ammarpad renamed this task from User page link is red in diff page edit summary despite global user page existing to User page link is red in diff and history pages edit summary despite global user page existing.Feb 18 2022, 7:16 AM
Ammarpad merged a task: T297192: Redlinked username in page history edit summaries despite a global user page existing.
Ammarpad added subscribers: AlexisJazz, stjn, Stang and 2 others.
Ammarpad triaged this task as Medium priority.Feb 18 2022, 7:45 AM
Ammarpad subscribed.

Tackling the oldest, there seems to be so many duplicates around here.

gerritbot added a comment.Feb 18 2022, 8:20 AM

Change 763693 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] CommentParser: Treat known titles as always known for linking

https://gerrit.wikimedia.org/r/763693

gerritbot added a project: Patch-For-Review.Feb 18 2022, 8:20 AM
gerritbot added a comment.Feb 21 2022, 1:56 AM

Change 763693 merged by jenkins-bot:

[mediawiki/core@master] CommentParser: Treat known titles as always known for linking

https://gerrit.wikimedia.org/r/763693

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 21 2022, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 21 2022, 2:10 AM
Ammarpad closed this task as Resolved.Feb 21 2022, 9:36 PM
Ammarpad claimed this task.

This is now fixed. Example from dup (T297192): https://en.wikipedia.org/w/index.php?title=User:Alexis_Jazz/sandbox3&diff=1059094223&oldid=1042208596

gerritbot added a comment.Feb 21 2022, 10:09 PM

Change 764445 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] CommentParser: Fix OR operation order.

https://gerrit.wikimedia.org/r/764445

gerritbot added a project: Patch-For-Review.Feb 21 2022, 10:09 PM
gerritbot added a comment.Feb 22 2022, 6:47 PM

Change 764445 merged by jenkins-bot:

[mediawiki/core@master] CommentParser: Optimise operation order (cache before isAlwaysKnown)

https://gerrit.wikimedia.org/r/764445

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.24; 2022-02-28); removed MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 22 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 22 2022, 7:11 PM
Tol mentioned this in T293707: Link to soft redirect in edit summary in page history is red.Feb 22 2022, 7:23 PM
Stang unsubscribed.Mar 18 2022, 1:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL