Error: Class 'MediaWiki\Extension\WikiEditor\ConfirmEditHooks' not found
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Nov 23 2021, 11:00 AM

Description

What is the problem?

There are lots of errors on beta cluster like:

2021-11-23 10:54:19 [YZzIVpZBhxOk3U@3gBBwxQAAAAQ] deployment-mediawiki11 commonswiki 1.38.0-alpha exception ERROR: [YZzIVpZBhxOk3U@3gBBwxQAAAAQ] /w/index.php?title=Malaysia_apos;s_Gravity-defying_Lion_Dancers_Brought_Down_To_Earth_By...&action=submit   Error: Class 'MediaWiki\Extension\WikiEditor\ConfirmEditHooks' not found {"exception_url":"/w/index.php?title=Malaysia_apos;s_Gravity-defying_Lion_Dancers_Brought_Down_To_Earth_By...&action=submit","reqId":"YZzIVpZBhxOk3U@3gBBwxQAAAAQ","caught_by":"entrypoint"} 
[Error Error] (/srv/mediawiki/php-master/extensions/WikiEditor/includes/Hooks.php:427) Class 'MediaWiki\Extension\WikiEditor\ConfirmEditHooks' not found
  #0 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(338): MediaWiki\Extension\WikiEditor\Hooks::editPageAttemptSaveAfter(EditPage, Status, array)
  #1 /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
  #2 /srv/mediawiki/php-master/includes/HookContainer/HookRunner.php(1557): MediaWiki\HookContainer\HookContainer->run(string, array)
  #3 /srv/mediawiki/php-master/includes/EditPage.php(1691): MediaWiki\HookContainer\HookRunner->onEditPage__attemptSave_after(EditPage, Status, array)
  #4 /srv/mediawiki/php-master/includes/EditPage.php(666): EditPage->attemptSave(array)
  #5 /srv/mediawiki/php-master/includes/actions/EditAction.php(71): EditPage->edit()
  #6 /srv/mediawiki/php-master/includes/actions/SubmitAction.php(38): EditAction->show()
  #7 /srv/mediawiki/php-master/includes/MediaWiki.php(534): SubmitAction->show()
  #8 /srv/mediawiki/php-master/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
  #9 /srv/mediawiki/php-master/includes/MediaWiki.php(910): MediaWiki->performRequest()
  #10 /srv/mediawiki/php-master/includes/MediaWiki.php(554): MediaWiki->main()
  #11 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
  #12 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
  #13 /srv/mediawiki/w/index.php(3): require(string)
  #14 {main}

Steps to reproduce problem

Edit an article on beta.

Details

Subject	Repo	Branch	Lines +/-
build: Load ConfirmEdit as phan dependency	mediawiki/extensions/WikiEditor	master	+2 -1
Zuul: [extensions/WikiEditor] Add ConfirmEdit as phan dependency	integration/config	master	+1 -1
Fix namespace for ConfirmEditHooks	mediawiki/extensions/WikiEditor	master	+1 -1

Customize query in gerrit

Event Timeline

dom_walden created this task.Nov 23 2021, 11:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2021, 11:00 AM

Change 740808 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/WikiEditor@master] Fix namespace for ConfirmEditHooks

https://gerrit.wikimedia.org/r/740808

gerritbot added a project: Patch-For-Review.Nov 23 2021, 11:10 AM

Zabe subscribed.Nov 23 2021, 11:10 AM

Change 740808 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Fix namespace for ConfirmEditHooks

https://gerrit.wikimedia.org/r/740808

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.Nov 23 2021, 4:00 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 23 2021, 4:00 PM

Thanks for the report.

The bug is in wmf.10, but that version is not being deployed (no train this week), so this shouldn't require backporting.

Change 740916 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[integration/config@master] Zuul: [extensions/WikiEditor] Add ConfirmEdit as phan dependency

https://gerrit.wikimedia.org/r/740916

Change 740917 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiEditor@master] build: Load ConfirmEdit as phan dependency

https://gerrit.wikimedia.org/r/740917

Sorry for the issue on my code review, but suppress/bypass phan for required classes is not good for this reason. I have changed the config to allow phan to find this issue.

Change 740916 merged by jenkins-bot: