[Bug] Additional horizontal padding displayed in QuickSurvey on mobile devices
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	AAlhazwani-WMF
	Nov 25 2021, 1:53 PM

Description

Steps to reproduce

Navigate to https://en.wikipedia.beta.wmflabs.org/wiki/User:Erayfield/sandbox

Expected results

QuickSurvey padding left and right set to 16px em equivalent.

Actual results

Derrick and Joaquin found that there's a specif minerva/mobilefrontend rule with .content which increases the horizontal padding of QuickSurvey

@media screen and (min-width: 720px)
.pre-content, .minerva-anon-talk-message, #mw-content-text > form, .content, .content-unstyled, .post-content {
    max-width: 993.3px;
    margin: 0 3.35em;
}

Environments observed

iPhone 13 Pro Max phone (iOS version 15) using Landscape orientation
Samsung FE20 phone (Android version 11) using Portrait orientation
Samsung Galaxy A10 tablet emulator (Android version 8.1) using Portrait orientation

Details

	Subject	Repo	Branch	Lines +/-
	Change survey content class name	mediawiki/extensions/QuickSurveys	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T303769: Return {{SERVERNAME}} to GDI Safety Survey question now that it is supported in mw.message

Event Timeline

AAlhazwani-WMF created this task.Nov 25 2021, 1:53 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptNov 25 2021, 1:53 PM

Madalina moved this task from Needs triage to Pre-estimation review on the Trust and Safety Tools Team Backlog board.Feb 22 2022, 12:32 PM

ARamirez_WMF set the point value for this task to 2.Mar 7 2022, 4:28 PM

ARamirez_WMF moved this task from Pre-estimation review to Ready for development on the Trust and Safety Tools Team Backlog board.

ARamirez_WMF moved this task from Ready for development to Kanban on the Trust and Safety Tools Team Backlog board.Mar 7 2022, 4:31 PM

ARamirez_WMF edited projects, added Trust and Safety Tools Team Backlog (Kanban); removed Trust and Safety Tools Team Backlog.

Scardenasmolinar changed the task status from Open to In Progress.Mar 7 2022, 4:32 PM

Scardenasmolinar claimed this task.

Scardenasmolinar moved this task from 🎬 Ready to 💻 In Progress on the Trust and Safety Tools Team Backlog (Kanban) board.

Change 769608 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/QuickSurveys@master] Change survey content class name

https://gerrit.wikimedia.org/r/769608

gerritbot added a project: Patch-For-Review.Mar 10 2022, 2:34 AM

Scardenasmolinar moved this task from 💻 In Progress to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.Mar 10 2022, 2:35 AM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/47a727c230/w/

Looking gooood @Scardenasmolinar ✨

Change 769608 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Change survey content class name

https://gerrit.wikimedia.org/r/769608

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 12 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2022, 1:10 AM

Sticking this in product sign-off since it's so straightforward and has been merged. Forgive me if I am advancing it too far!

jsn.sherman moved this task from 🤘 Done to 🐛 QA on the Trust and Safety Tools Team Backlog (Kanban) board.Mar 14 2022, 3:36 PM

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/47a727c230/w/~~

I have verified this defect has been resolved for the devices listed in the ticket Description, and I have also verified this code fix did not effect the existing screen layout of the Quick Survey on the other browsers or devices.

Compatibility Testing was performed on the following:
Desktop – Firefox version 98 / Chrome version 99 / Microsoft Edge version 99 / Opera version 84 / Safari version 15.

Mobile Devices – Android version 12 Samsung FE20 phone / Android version 8.1 Galaxy A10 tablet / iOS version 15 iPad Pro 5th generation / iOS version 15 iPhone 13 Pro Max.

Below are screenshots of new code change:
(NOTE: please disregard blurriness of screenshots, this is due to device simulation and is not related to the code change):

screenshots for iPhone 13 Pro Max / iOS version 15:

screenshots for Samsung FE 20 phone / Android version 12:

screenshots for Samsung Galaxy A10 tablet emulator / Android version 8.1:

Djackson-ctr moved this task from 🐛 QA to 🤘 Done on the Trust and Safety Tools Team Backlog (Kanban) board.Mar 14 2022, 5:48 PM

Djackson-ctr mentioned this in T303769: Return {{SERVERNAME}} to GDI Safety Survey question now that it is supported in mw.message.Mar 15 2022, 9:40 PM

Looks good to me!

	F35005538: image.png
	Mar 14 2022, 5:47 PM

	F35005529: image.png
	Mar 14 2022, 5:47 PM

	F35005580: image.png
	Mar 14 2022, 5:47 PM

	F35005560: image.png
	Mar 14 2022, 5:47 PM

[Bug] Additional horizontal padding displayed in QuickSurvey on mobile devicesClosed, ResolvedPublic2 Estimated Story PointsActions