"Insert link" dialog: Empty title alert only shows key of message when pressing Enter
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 5 2022, 10:06 AM

Description

What is the problem?

When using the "Insert link" dialog, if I don't enter a title and press the Enter key, I get an alert saying:

⧼wikieditor-toolbar-tool-link-empty⧽

This is the key of the message, rather than the message itself.

The message itself will depend on the user's interface language. If the user's interface language is English, the alert should say:

You did not enter anything to link to.

Steps to reproduce problem

Go to any page on a wiki (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:Random)
Open the WikiEditor
Click the "Insert link" menu item (tooltip: "Link")
Press the Enter key

Expected behavior: The alert says: You did not enter anything to link to (if you are testing in English, otherwise translated into your interface language)
Observed behavior: The alert says: ⧼wikieditor-toolbar-tool-link-empty⧽

Environment

Browser: Firefox and Chrome (did not test IE, Edge or Safari)
Wiki(s): https://test.wikipedia.org MediaWiki 1.38.0-wmf.16 (rMWdc3e3a80f955) 12:29, 4 January 2022, WikiEditor 0.5.3 (2e5791c) 08:31, 27 December 2021.
Editor, if applicable: WikiEditor

Screenshots

Details

Subject	Repo	Branch	Lines +/-
Check for disabled button in click handler	mediawiki/extensions/WikiEditor	master	+92 -86
Remove out of date invalid link alert	mediawiki/extensions/WikiEditor	master	+0 -9
Properly disable insert-link button	mediawiki/extensions/WikiEditor	master	+1 -8

Customize query in gerrit

Related Objects

Mentioned Here: T297371: Insert link search dropdown appears incorrectly after entering several links
T298549: Insert link dialog: After clicking the Cancel button, it does not insert a link if you press the Enter key
rEWED2e5791ca326d: Localisation updates from https://translatewiki.net.
rMWdc3e3a80f955: Update git submodules

Event Timeline

dom_walden created this task.Jan 5 2022, 10:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2022, 10:06 AM

Change 752597 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Properly disable insert-link button

https://gerrit.wikimedia.org/r/752597

gerritbot added a project: Patch-For-Review.Jan 10 2022, 7:38 AM

This alert should not actually exist at all any more. Rather than fixing the message, we need to remove the whole thing because it should never be possible to click 'Insert link' when the target is empty.

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-16) board.Jan 10 2022, 7:40 AM

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-17); removed Community-Tech (CommTech-Sprint-16).Jan 18 2022, 8:13 PM

ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-17) board.Jan 18 2022, 8:22 PM

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-18); removed Community-Tech (CommTech-Sprint-17).Jan 31 2022, 2:32 PM

ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-18) board.Jan 31 2022, 2:35 PM

Change 752597 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Properly disable insert-link button

https://gerrit.wikimedia.org/r/752597

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-18) board.Feb 8 2022, 4:28 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 8 2022, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2022, 5:10 AM

@Samwilson I am finding that when I open the "Insert link" dialog and press enter, it inserts an empty link ([[]]). Both on beta and my local docker.

Change 761867 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Check for disabled button in click handler

https://gerrit.wikimedia.org/r/761867

gerritbot added a project: Patch-For-Review.Feb 11 2022, 7:43 AM

Thanks for finding this @dom_walden. There was me thinking that a disabled button would be protected against being clicked, but no!

Change 761873 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Remove out of date invalid link alert

https://gerrit.wikimedia.org/r/761873

Change 761873 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Remove out of date invalid link alert

https://gerrit.wikimedia.org/r/761873

Change 761867 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Check for disabled button in click handler

https://gerrit.wikimedia.org/r/761867

Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-18) board.Feb 11 2022, 11:25 PM

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-19); removed Community-Tech (CommTech-Sprint-18).Feb 15 2022, 10:22 PM

• JMcLeod_WMF moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-19) board.Feb 15 2022, 10:29 PM

I have not been able to reproduce the original bug, i.e. I cannot find a way to submit the "Insert link" dialog when the first input field is empty (with the exception of this circumstance T298549).

The "Insert link" dialog has a lot of state behaviour (see state diagram). So, I tried to reproduce the bug after one or more of these states has been triggered, especially in a long sequence as I know this can cause other bugs (e.g. T297371, T298549):

Tested entering several different types of links in a row and then trying to repro
Tried to repro with the dialog in various "saved" states
Tried to repro after looping between various states

I got distracted investigating and reporting unrelated bugs in the "Insert link" dialog, so I wasn't as focused as I could have been.

Moreover, there are lots of states in which the "Insert link" dialog behaves a bit weirdly. No doubt there are some states I have missed. There could be bugs in this area I have not caught yet.

• JMcLeod_WMF removed a project: Community-Tech (CommTech-Sprint-19).Mar 1 2022, 6:43 PM

• JMcLeod_WMF added a project: Community-Tech (CommTech-Sprint-20).Mar 1 2022, 6:53 PM

• JMcLeod_WMF moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-20) board.Mar 1 2022, 6:59 PM

@dom_walden thanks for investigating related bugs. Going to resolve this ticket and we can triage whether the bugs you unveiled were pre-existing or already existed

• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-20) board.Mar 16 2022, 11:49 AM

happy5214 moved this task from Backlog to Closed on the WikiEditor board.Jul 31 2023, 9:55 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 10:10 PM

"Insert link" dialog: Empty title alert only shows key of message when pressing EnterClosed, ResolvedPublicBUG REPORTActions