Page MenuHomePhabricator

script_tests.TestScriptSimulate.speedy_delete somtimes fails when the user is not logged in
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce:
https://github.com/wikimedia/pywikibot/runs/4763223520?check_suite_focus=true

What happens?:

======================================================================
FAIL: test_speedy_delete (tests.script_tests.TestScriptSimulate)
Test running speedy_delete -simulate.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/pywikibot/pywikibot/tests/script_tests.py", line 238, in test_script
    self.assertIn(error, result['stderr'])
AssertionError: "does not have 'delete' right for site" not found in 'WARNING: /home/runner/work/pywikibot/pywikibot/pywikibot/bot.py:873: UserWarning: Site objects have been created before arguments were handled\n  UserWarning)\n\nWARNING: No user is logged in on site wikisource:zh\nLogin first.\n'

----------------------------------------------------------------------

What should have happened instead?:
The test should skip instead

Software version:

Pywikibot: [https] wikimedia-pywikibot (cb07ee0, g1, 2022/01/10, 15:13:31, master)
Release version: 7.0.0.dev0
setuptools version: 60.5.0
mwparserfromhell version: 0.6.3
wikitextparser version: 0.48.0
requests version: 2.27.1
  cacerts: /opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/certifi/cacert.pem
    certificate test: ok
Python: 3.7.12 (default, Sep  6 2021, 07:19:30) 
[GCC 9.3.0]
PYWIKIBOT_DIR: Not set
PYWIKIBOT_DIR_PWB: ''
PYWIKIBOT_NO_USER_CONFIG: Not set
PYWIKIBOT_TESTS_RUNNING: 1
PYWIKIBOT_TEST_NO_RC: 0
PYWIKIBOT_TEST_PROD_ONLY: 1
PYWIKIBOT_USERNAME: Pywikibot-test

Event Timeline

Xqt triaged this task as High priority.Jan 10 2022, 3:41 PM

Change 752690 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Remove TestLoginLogout test from site_tests

https://gerrit.wikimedia.org/r/752690

Change 752690 merged by jenkins-bot:

[pywikibot/core@master] [tests] Remove TestLoginLogout test from site_tests

https://gerrit.wikimedia.org/r/752690