Page MenuHomePhabricator
Create Task
Maniphest T300338

Exception thrown while running DataSender::sendData: Invalid URL
Open, Needs TriagePublicBUG REPORT
Actions

Description

Shows up a handful of times in logs (example).

Invalid URL http://?????????/mediawiki/load.php?debug=false&lang=en&modules=mediawiki.legacy.commonPrint,shared|skins.monobook&only=styles&skin=monobook&* specified for reference Flow\Model\URLReference

from /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Model/URLReference.php(27)
#0 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Model/URLReference.php(64): Flow\Model\URLReference->__construct(Flow\Model\UUID, string, Flow\Model\UUID, Title, string, Flow\Model\UUID, string, string)
#1 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Data/Mapper/BasicObjectMapper.php(40): Flow\Model\URLReference::fromStorageRow(array, NULL)
#2 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Data/ObjectLocator.php(315): Flow\Data\Mapper\BasicObjectMapper->fromStorageRow(array)
#3 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Data/ObjectManager.php(307): Flow\Data\ObjectLocator->load(array)
#4 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Data/ObjectLocator.php(119): Flow\Data\ObjectManager->load(array)
#5 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Data/ObjectLocator.php(70): Flow\Data\ObjectLocator->findMulti(array, array)
#6 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Data/ManagerGroup.php(127): Flow\Data\ObjectLocator->find(array)
#7 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Data/ManagerGroup.php(139): Flow\Data\ManagerGroup->call(string, array)
#8 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/LinksTableUpdater.php(124): Flow\Data\ManagerGroup->find(string, array)
#9 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/LinksTableUpdater.php(44): Flow\LinksTableUpdater->getReferencesForTitle(Title)
#10 /srv/mediawiki/php-1.38.0-wmf.19/extensions/Flow/includes/Content/BoardContentHandler.php(217): Flow\LinksTableUpdater->mutateParserOutput(Title, ParserOutput)
#11 /srv/mediawiki/php-1.38.0-wmf.19/includes/content/ContentHandler.php(1723): Flow\Content\BoardContentHandler->fillParserOutput(Flow\Content\BoardContent, MediaWiki\Content\Renderer\ContentParseParams, ParserOutput)
#12 /srv/mediawiki/php-1.38.0-wmf.19/includes/content/Renderer/ContentRenderer.php(47): ContentHandler->getParserOutput(Flow\Content\BoardContent, MediaWiki\Content\Renderer\ContentParseParams)
#13 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RenderedRevision.php(271): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(Flow\Content\BoardContent, Title, integer, ParserOptions, boolean)
#14 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RenderedRevision.php(238): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(Flow\Content\BoardContent, boolean)
#15 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RevisionRenderer.php(221): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#16 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RevisionRenderer.php(158): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#17 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#18 /srv/mediawiki/php-1.38.0-wmf.19/includes/Revision/RenderedRevision.php(200): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#19 /srv/mediawiki/php-1.38.0-wmf.19/includes/content/ContentHandler.php(1443): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput(array)
#20 /srv/mediawiki/php-1.38.0-wmf.19/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(85): ContentHandler->getParserOutputForIndexing(WikiPage, ParserCache)
#21 /srv/mediawiki/php-1.38.0-wmf.19/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(68): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalizeReal(Elastica\Document, WikiPage, ParserCache, CirrusSearch\CirrusSearch)
#22 /srv/mediawiki/php-1.38.0-wmf.19/extensions/CirrusSearch/includes/BuildDocument/BuildDocument.php(171): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalize(Elastica\Document, Title)
#23 /srv/mediawiki/php-1.38.0-wmf.19/extensions/CirrusSearch/includes/DataSender.php(317): CirrusSearch\BuildDocument\BuildDocument->finalize(Elastica\Document)
#24 /srv/mediawiki/php-1.38.0-wmf.19/extensions/CirrusSearch/includes/Job/ElasticaWrite.php(136): CirrusSearch\DataSender->sendData(string, array)
#25 /srv/mediawiki/php-1.38.0-wmf.19/extensions/CirrusSearch/includes/Job/JobTraits.php(136): CirrusSearch\Job\ElasticaWrite->doJob()
#26 /srv/mediawiki/php-1.38.0-wmf.19/extensions/EventBus/includes/JobExecutor.php(79): CirrusSearch\Job\CirrusGenericJob->run()
#27 /srv/mediawiki/rpc/RunSingleJob.php(76): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#28 {main}

Event Timeline

Tgr created this task.Jan 28 2022, 9:19 AM
Restricted Application added projects: Growth-Team, Discovery-Search. · View Herald TranscriptJan 28 2022, 9:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr moved this task from Inbox to Triaged on the Growth-Team board.Jan 28 2022, 9:36 AM
Tgr added a project: Wikimedia-production-error.Jan 28 2022, 10:09 AM

Flow bug, low frequency, Flow search doesn't really work anyway so probably no user impact, just some logspam.

Gehel moved this task from needs triage to watching / waiting on the Discovery-Search board.Jan 31 2022, 4:25 PM
Gehel subscribed.

The Search Platform team is not going to work on this, our expectation is that there is an issue in the rendering of a Flow page. As mentioned by @Tgr, the impact is low. A few Flow pages are not indexed properly, but this isn't a major Search target.

Krinkle moved this task from Untriaged to Jan 2022 on the Wikimedia-production-error board.Feb 4 2022, 3:12 AM
thcipriani edited projects, added Unstewarded-production-error; removed Discovery-Search, Growth-Team.Feb 29 2024, 4:28 PM
thcipriani moved this task from Jan 2022 to Older on the Wikimedia-production-error board.
Wargo subscribed.Tue, Apr 16, 6:37 PM

This is because we check validity of URLs using wfParseUrlduring reading external links from flow_ext_ref but not during filling "reference" tables. This causes filling database with wrong links when they are inserted into messages (posts) and these alarms.

To confirm I am not wrong, we need to search flow post with this content: http://?????????/mediawiki and see what metadata is created and what is done with them.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL