Page MenuHomePhabricator

DiscussionTools hides cite errors
Closed, ResolvedPublic

Description

DiscussionTools hides cite errors. I noticed this while debugging T301213 (and it made that bug more difficult to understand).

For example, see this page: https://test.wikipedia.org/w/index.php?title=Talk:Cite_error&action=edit

== test ==

hi [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 05:42, 16 February 2022 (UTC)

:hello <ref>?<ref> [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 05:43, 16 February 2022 (UTC)
::hello <ref>?</ref> [[User:Matma Rex|Matma Rex]] ([[User talk:Matma Rex|talk]]) 05:43, 16 February 2022 (UTC)

The unclosed <ref> tag in the second comment causes the third comment not to be visible on the page (because all content up to the </ref> is replaced with an error).

With the reply tool enabled, there is no indication that anything is wrong:
https://test.wikipedia.org/wiki/Talk:Cite_error?dtenable=1:

image.png (211×1 px, 20 KB)

With the reply tool disabled, there's a clear error message:
https://test.wikipedia.org/wiki/Talk:Cite_error?dtenable=0:
image.png (211×1 px, 29 KB)

Event Timeline

Change 763101 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Cite@master] Remove hack that hides ref errors unnecessarily

https://gerrit.wikimedia.org/r/763101

I just noticed that this problem was also reported here yesterday (weird coincidence if it really has been broken forever, but I swear I haven't seen it before): https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Disappearing_chunks_of_talkpage_text

Change 763101 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove hack that hides ref errors unnecessarily

https://gerrit.wikimedia.org/r/763101

As expected, Discussion Tools shows cite errors irrespective of the state of Discussion Tools enabled or disabled. See

Screenshot 2022-03-08 at 15.40.56.png (328×2 px, 84 KB)

Another case of using the source editor:

Screenshot 2022-03-08 at 15.45.59.png (656×2 px, 113 KB)

ppelberg claimed this task.