Page MenuHomePhabricator
Create Task
Maniphest T302540

Missing PHP extension in MW core's composer.json
Open, Needs TriagePublic
Actions

Description

Not all of these are necessary to run MW... But they're used in code, so should at *least* be in suggest (if not require or require-dev).

We may want to promote some suggest entries too.

Not every one being added will mean admins/dev need to install anything, but some packages do do weird things...

  • ext-calendar (code change and docu: PHP configuration | Manual:Installation requirements)
  • ext-curl (in suggests)
  • ext-gd
  • ext-gmp
  • ext-mysqli (now in suggests)
  • ext-openssl (in suggests)
  • ext-pcntl (now in suggests)
  • ext-pdo (now in suggests)
  • ext-pgsql (now in suggests)
  • ext-posix (now in suggests)
  • ext-readline (now in suggests)
  • ext-simplexml (code change)
  • ext-sockets (now in suggests)
  • ext-zlib (now in suggests)

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Feb 24 2022, 11:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2022, 11:23 PM
Reedy updated the task description. (Show Details)Feb 24 2022, 11:26 PM
Reedy updated the task description. (Show Details)Feb 24 2022, 11:37 PM
Reedy added a subscriber: Florian.
Reedy added a project: Composer.Feb 25 2022, 12:29 AM
Reedy moved this task from Backlog to Features/Improvements on the Composer board.Feb 25 2022, 12:47 AM
gerritbot added a comment.Feb 25 2022, 12:45 PM

Change 766089 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] composer.json: Add ext-calendar to require

https://gerrit.wikimedia.org/r/766089

gerritbot added a project: Patch-For-Review.Feb 25 2022, 12:45 PM

Change 766090 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] composer.json: Add ext-simplexml to require-dev

https://gerrit.wikimedia.org/r/766090

Florian updated the task description. (Show Details)Feb 25 2022, 5:55 PM
gerritbot added a comment.Feb 25 2022, 6:06 PM

Change 766089 merged by jenkins-bot:

[mediawiki/core@master] composer.json: Add ext-calendar to require

https://gerrit.wikimedia.org/r/766089

gerritbot added a comment.Feb 25 2022, 6:08 PM

Change 766090 merged by jenkins-bot:

[mediawiki/core@master] composer.json: Add ext-simplexml to require-dev

https://gerrit.wikimedia.org/r/766090

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2022, 6:10 PM
gerritbot added a comment.Feb 25 2022, 6:58 PM

Change 766184 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] composer.json: Add DB drivers to suggests

https://gerrit.wikimedia.org/r/766184

gerritbot added a project: Patch-For-Review.Feb 25 2022, 6:58 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 25 2022, 7:00 PM
Mainframe98 subscribed.Feb 26 2022, 11:33 AM

Note that the posix extension is not available on Windows. Neither is pcntl. Adding these to either require or require-dev will break MediaWiki on Windows. See T192167#5722267.

Reedy added a comment.Feb 26 2022, 4:44 PM

Hence me saying that they should be in at least ‘suggest’

gerritbot added a comment.Mar 5 2022, 3:59 PM

Change 766184 merged by jenkins-bot:

[mediawiki/core@master] composer.json: Add DB drivers to suggests

https://gerrit.wikimedia.org/r/766184

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 5 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 5 2022, 4:10 PM
Reedy updated the task description. (Show Details)Mar 5 2022, 10:14 PM
gerritbot added a comment.Mar 5 2022, 10:38 PM

Change 768258 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] composer.json: Add 7 more PHP extensions to suggest

https://gerrit.wikimedia.org/r/768258

gerritbot added a project: Patch-For-Review.Mar 5 2022, 10:38 PM
gerritbot added a comment.Mar 6 2022, 12:46 AM

Change 768265 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] composer.json: Document what the suggested php extensions enable

https://gerrit.wikimedia.org/r/768265

gerritbot added a comment.Mar 6 2022, 1:02 AM

Change 768258 merged by jenkins-bot:

[mediawiki/core@master] composer.json: Add 7 more PHP extensions to suggest

https://gerrit.wikimedia.org/r/768258

gerritbot added a comment.Mar 11 2022, 12:52 PM

Change 769955 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_35] composer.json: Add ext-calendar to require

https://gerrit.wikimedia.org/r/769955

gerritbot added a comment.Mar 11 2022, 12:52 PM

Change 769956 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_35] composer.json: Add ext-simplexml to require-dev

https://gerrit.wikimedia.org/r/769956

gerritbot added a comment.Mar 11 2022, 12:52 PM

Change 769957 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_35] composer.json: Add DB drivers to suggests

https://gerrit.wikimedia.org/r/769957

gerritbot added a comment.Mar 11 2022, 12:52 PM

Change 769958 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_35] composer.json: Add 7 more PHP extensions to suggest

https://gerrit.wikimedia.org/r/769958

gerritbot added a comment.Mar 11 2022, 12:54 PM

Change 769959 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_36] composer.json: Add ext-calendar to require

https://gerrit.wikimedia.org/r/769959

gerritbot added a comment.Mar 11 2022, 12:54 PM

Change 769960 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_36] composer.json: Add ext-simplexml to require-dev

https://gerrit.wikimedia.org/r/769960

gerritbot added a comment.Mar 11 2022, 12:54 PM

Change 769961 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_36] composer.json: Add DB drivers to suggests

https://gerrit.wikimedia.org/r/769961

gerritbot added a comment.Mar 11 2022, 12:54 PM

Change 769962 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_36] composer.json: Add 7 more PHP extensions to suggest

https://gerrit.wikimedia.org/r/769962

gerritbot added a comment.Mar 11 2022, 12:56 PM

Change 769963 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_37] composer.json: Add ext-calendar to require

https://gerrit.wikimedia.org/r/769963

gerritbot added a comment.Mar 11 2022, 12:56 PM

Change 769964 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_37] composer.json: Add ext-simplexml to require-dev

https://gerrit.wikimedia.org/r/769964

gerritbot added a comment.Mar 11 2022, 12:56 PM

Change 769965 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_37] composer.json: Add DB drivers to suggests

https://gerrit.wikimedia.org/r/769965

gerritbot added a comment.Mar 11 2022, 12:56 PM

Change 769966 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_37] composer.json: Add 7 more PHP extensions to suggest

https://gerrit.wikimedia.org/r/769966

Reedy updated the task description. (Show Details)Mar 11 2022, 12:59 PM
gerritbot added a comment.Mar 11 2022, 1:07 PM

Change 769955 merged by jenkins-bot:

[mediawiki/core@REL1_35] composer.json: Add ext-calendar to require

https://gerrit.wikimedia.org/r/769955

gerritbot added a comment.Mar 11 2022, 1:07 PM

Change 769956 merged by jenkins-bot:

[mediawiki/core@REL1_35] composer.json: Add ext-simplexml to require-dev

https://gerrit.wikimedia.org/r/769956

gerritbot added a comment.Mar 11 2022, 1:08 PM

Change 769957 merged by jenkins-bot:

[mediawiki/core@REL1_35] composer.json: Add DB drivers to suggests

https://gerrit.wikimedia.org/r/769957

gerritbot added a comment.Mar 11 2022, 1:09 PM

Change 769958 merged by jenkins-bot:

[mediawiki/core@REL1_35] composer.json: Add 7 more PHP extensions to suggest

https://gerrit.wikimedia.org/r/769958

gerritbot added a comment.Mar 11 2022, 1:12 PM

Change 769959 merged by jenkins-bot:

[mediawiki/core@REL1_36] composer.json: Add ext-calendar to require

https://gerrit.wikimedia.org/r/769959

gerritbot added a comment.Mar 11 2022, 1:12 PM

Change 769960 merged by jenkins-bot:

[mediawiki/core@REL1_36] composer.json: Add ext-simplexml to require-dev

https://gerrit.wikimedia.org/r/769960

gerritbot added a comment.Mar 11 2022, 1:12 PM

Change 769961 merged by jenkins-bot:

[mediawiki/core@REL1_36] composer.json: Add DB drivers to suggests

https://gerrit.wikimedia.org/r/769961

gerritbot added a comment.Mar 11 2022, 1:13 PM

Change 769962 merged by jenkins-bot:

[mediawiki/core@REL1_36] composer.json: Add 7 more PHP extensions to suggest

https://gerrit.wikimedia.org/r/769962

gerritbot added a comment.Mar 11 2022, 1:13 PM

Change 769963 merged by jenkins-bot:

[mediawiki/core@REL1_37] composer.json: Add ext-calendar to require

https://gerrit.wikimedia.org/r/769963

gerritbot added a comment.Mar 11 2022, 1:37 PM

Change 769964 merged by jenkins-bot:

[mediawiki/core@REL1_37] composer.json: Add ext-simplexml to require-dev

https://gerrit.wikimedia.org/r/769964

gerritbot added a comment.Mar 11 2022, 1:38 PM

Change 769965 merged by jenkins-bot:

[mediawiki/core@REL1_37] composer.json: Add DB drivers to suggests

https://gerrit.wikimedia.org/r/769965

gerritbot added a comment.Mar 11 2022, 1:46 PM

Change 769966 merged by jenkins-bot:

[mediawiki/core@REL1_37] composer.json: Add 7 more PHP extensions to suggest

https://gerrit.wikimedia.org/r/769966

ReleaseTaggerBot added projects: MW-1.35-notes, MW-1.36-notes, MW-1.37-notes.Mar 11 2022, 2:00 PM
gerritbot added a comment.Mar 11 2022, 2:02 PM

Change 768265 merged by jenkins-bot:

[mediawiki/core@master] composer.json: Document what the suggested php extensions enable

https://gerrit.wikimedia.org/r/768265

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.26; 2022-03-14); removed MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 11 2022, 3:00 PM
Florian unsubscribed.Mar 11 2022, 6:03 PM
Florian subscribed.
Jdforrester-WMF subscribed.Apr 12 2022, 10:28 AM
Kghbln subscribed.Apr 21 2022, 10:20 AM

Please remember to also update Manual:Installation requirements in case requirements are being added.

Kghbln updated the task description. (Show Details)Apr 21 2022, 10:21 AM
Reedy added a comment.Apr 21 2022, 10:43 AM

Technically no requirements are being added; they were needed already. MW would've just failed if/when the code was executed, so this at least tries to add them as a pre-flight check.

Though in the cases for some of them, they're generally bundled in with a PHP install. Only some distros pull them into seperate packages...

Kghbln added a comment.Apr 21 2022, 11:00 AM

Thanks for the insight. I only happened to look for this here since two different people grumped with me during the past weeks about this requirement missing from the SMW installation docu. This made me look around. Obviously they used one of these distros.

Reedy added a comment.Apr 21 2022, 6:14 PM

https://github.com/wikimedia/mediawiki/blame/master/includes/actions/HistoryAction.php#L117

That line was added in rMW1b27cee8979b: Make HistoryAction form use OOUI... So in theory ext-calendar has been needed since at least 1.33

Kghbln added a comment.Apr 22 2022, 2:37 PM

Interesting. I just wonder why people all of a sudden start to be grumpy with me. Some sort of bad karma and people not upgrading as often as they should.

Reedy added a comment.Apr 22 2022, 2:50 PM

Haha, I mean it's possible they're also not exercising that part of the code... Which is certainly possible. Whereas this causes install/update time checks makes this fail unconditionally if it's not met. Which was my intention.. Rather than it failing randomly in use after MediaWiki had installed happily like everything it needed was included :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL