| STran | |
| Mar 9 2022, 5:38 PM |
| F35021582: Screen Shot 2022-03-23 at 3.41.30 PM.png | |
| Mar 23 2022, 8:44 PM |
| F35020675: Screen Shot 2022-03-22 at 11.30.41 PM.png | |
| Mar 23 2022, 3:33 AM |
After T300245: Log when the infobox is expanded or collapsed, the log function calls mw.trackSubscribe on every log, rebinding the listener and causing a compounding number of events to be sent as ip interactions occur. mw.trackSubscribe should only be called once.
To reproduce:
AC:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Stop subscribing to listeners on every log() call | mediawiki/extensions/IPInfo | master | +17 -9 |
Change 771330 had a related patch set uploaded (by STran; author: STran):
[mediawiki/extensions/IPInfo@master] Stop subscribing to listeners on every log() call
Change 771330 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Stop subscribing to listeners on every log() call
One event shows per an IP Info box that is clicked to open popup. If you click the same IP info box to pop open again, no additional events is generated.
Below one log for each action although the user clicked IP info popup more than once
