Maniphest T306041

Use 'info' icon for the popup button
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Apr 13 2022, 3:26 PM

Tags

Referenced Files

	F35062164: Screen Shot 2022-04-21 at 6.44.54 PM.png
	Apr 22 2022, 3:34 AM

Subscribers

Tokens

"Piece of Eight" token, awarded by Prtksxna.

Description

Background

In T301938, we replaced the info icon with infoFilled.
As discussed with @Prtksxna on that task, infoFilled looks larger than expected, and designs for a smaller version of the icon may take some time
So we want to go back to using info instead
There are no current plans to return to infoFilled

To do this, we need to revert T301938#7787355.

But we also need to revert T301938#7788011, which fixed a bug that was reintroduced by the first patch.

Acceptance criteria

Use 'info' icon for the popup button
Don't re-introduce T268981: SPIKE: IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox) [8H]
Don't re-introduce T298942: Fix clipping of icon for IPInfo popups when language is set to ar [S]

Details

	Subject	Repo	Branch	Lines +/-
	Use 'info' icon for the popup button	mediawiki/extensions/IPInfo	master	+3 -6

Customize query in gerrit

Related Objects

Mentioned In: T301938: IPInfo: Use infoFilled for the popup button
T299878: i button clipped in RTL Minerva on Special:Log
Mentioned Here: T268981: SPIKE: IPInfo: Dotted lines on revision history jumps when opening popup (only on Firefox) [8H]
T298942: Fix clipping of icon for IPInfo popups when language is set to ar [S]
T301938: IPInfo: Use infoFilled for the popup button

Event Timeline

Tchanders created this task.Apr 13 2022, 3:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2022, 3:26 PM

• Prtksxna mentioned this in T299878: i button clipped in RTL Minerva on Special:Log.Apr 14 2022, 4:46 AM

• AGueyte set the point value for this task to 2.Apr 19 2022, 4:56 PM

Tchanders moved this task from Triage/To be Estimated to AHaT Sprint 6: The Bigouden on the Anti-Harassment board.Apr 19 2022, 5:01 PM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 6: The Bigouden); removed Anti-Harassment.

• AGueyte claimed this task.Apr 19 2022, 8:04 PM

Tchanders mentioned this in T301938: IPInfo: Use infoFilled for the popup button.Apr 19 2022, 8:59 PM

• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 19 2022, 10:06 PM

Change 784335 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] Use 'info' icon for the popup button

https://gerrit.wikimedia.org/r/784335

gerritbot added a project: Patch-For-Review.Apr 19 2022, 10:36 PM

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 19 2022, 10:46 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 20 2022, 4:01 PM

Change 784335 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Use 'info' icon for the popup button

https://gerrit.wikimedia.org/r/784335

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2022, 4:31 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.9; 2022-04-25).Apr 20 2022, 5:00 PM

Screen Shot 2022-04-21 at 6.44.54 PM.png (1×2 px, 582 KB)

• imaigwilo moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 6: The Bigouden) board.Apr 26 2022, 3:06 AM

• Prtksxna awarded a token.Apr 27 2022, 1:53 PM

Niharika closed this task as Resolved.May 17 2022, 5:23 PM

Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM