Page MenuHomePhabricator

[Realtime Preview] Make whole manual-mode bar clickable
Closed, ResolvedPublic

Description

This task is split out from T304568#7856435.

On that note, see also the question at https://phabricator.wikimedia.org/T304568#7854636. We're thinking the Reload buttons should be hidden/disabled while loading is taking place, so that they don't appear clickable when they don't do anything.

Agree with the above.

In addition let's make the whole gray area clickable, including the area outside of the button in this screenshot:

Screen Shot 2022-04-14 at 3.37.54 PM.png (150×1 px, 174 KB)

This should help us to mitigate @DLynch's concerns, so if folks are confused the whole area is clickable and hopefully there's enough context where they understand it's not a reload of the whole page:

As a complete drive-by comment, I'd be worried about confusion over whether "reload" means to reload the entire page, and that causing user worries about data-loss.


Other thoughts:

The blue button text should stay blue, but no longer be a button. The focus, cursor, tooltip, accesskey, etc. should all be moved to be on the whole bar.

The bar should be disabled and (as it currently is) be dimmed during preview-loading.

Event Timeline

Samwilson updated the task description. (Show Details)

Moving to current sprint as this is work from an existing task.

UsernameInvalid renamed this task from [Realtime Preview] Make whole manual-mode bar clickable to ywsfabwmr68@gmail.com.Apr 21 2022, 3:59 AM
UsernameInvalid triaged this task as Unbreak Now! priority.
JJMC89 renamed this task from ywsfabwmr68@gmail.com to [Realtime Preview] Make whole manual-mode bar clickable.Apr 21 2022, 4:01 AM
JJMC89 lowered the priority of this task from Unbreak Now! to Needs Triage.

@nayoub @NRodriguez Should the whole bar be dimmed during loading, or just the "Reload" blue text? The blue snake is not dimmed, and (at the moment) appears below the bar:

realtime_preview_loading.png (192×1 px, 21 KB)

To me, this feels a bit odd. The only other things that dim in this way are the elements (preview area, title, categories, etc.) that are changed via the wikitext that's being previewed. This bar is not part of the same set of content.

Change 785113 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] [Realtime Preview] Make whole manual-loading bar clickable

https://gerrit.wikimedia.org/r/785113

Test wiki created on Patch demo by Samwilson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/837c770115/w/

Change 785113 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: Make whole manual-loading bar clickable

https://gerrit.wikimedia.org/r/785113

Confirm that the whole manual reload bar is clickable

Screen Shot 2022-05-11 at 10.56.14 PM.png (892×2 px, 543 KB)

Test wiki on Patch demo by Samwilson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/837c770115/w/