Page MenuHomePhabricator
Create Task
Maniphest T30789

Dialog allows to insert invalid urls
Open, MediumPublic
Actions

Description

Steps to reproduce:

  1. Open a page for editing, chose the insert link dialog.
  2. Enter "a a" as url
  3. Chose "To an external web page" (If you ask why someone should do this, I can only say that I don't know, but that I've seen too many of these links to ignore them)
  4. Click "Insert Link"

Result: [http://a%20a a a] is inserted.
Expected result: The insert link button should be grayed out when the link to be inserted is definitely invalid.

Version: unspecified
Severity: normal

Details

Reference
bz28789
SubjectRepoBranchLines +/-
Link dialog: do basic URI validationmediawiki/extensions/WikiEditormaster+37 -12
Link dialog: do basic URI validationmediawiki/extensions/WikiEditormaster+42 -28
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:32 PM
• bzimport added a project: WikiEditor.
• bzimport set Reference to bz28789.
• bzimport added a subscriber: Unknown Object (MLST).
Schnark created this task.May 3 2011, 8:58 AM
• bzimport added a comment.Aug 19 2011, 7:12 PM

mhershberger wrote:

Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

gerritbot added a comment.Jun 22 2014, 11:22 PM

Change 141367 had a related patch set uploaded by TheDJ:
Link dialog: do basic URI validation

https://gerrit.wikimedia.org/r/141367

gerritbot added a comment.Oct 26 2014, 1:07 PM

Change 141367 abandoned by TheDJ:
Link dialog: do basic URI validation

Reason:
No reviewers willing to review

https://gerrit.wikimedia.org/r/141367

Jdforrester-WMF removed a project: Patch-For-Review.Dec 2 2014, 10:16 PM
Jdforrester-WMF set Security to None.
gerritbot subscribed.Nov 25 2015, 5:31 PM

Change 141367 had a related patch set uploaded (by Paladox):
Link dialog: do basic URI validation

https://gerrit.wikimedia.org/r/141367

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2015, 5:31 PM
gerritbot added a project: Patch-For-Review.Nov 25 2015, 5:31 PM
• Huonenwiki closed this task as a duplicate of T194968: Enable search in all wikidata namespaces combined.May 18 2018, 5:38 PM
Smalyshev reopened this task as Open.May 18 2018, 5:42 PM
happy5214 claimed this task.Nov 20 2019, 8:37 AM
gerritbot added a comment.Nov 21 2019, 11:39 PM

Change 552359 had a related patch set uploaded (by Happy5214; owner: Happy5214):
[mediawiki/extensions/WikiEditor@master] Link dialog: do basic URI validation

https://gerrit.wikimedia.org/r/552359

happy5214 moved this task from Backlog to Doing on the WikiEditor board.Nov 25 2019, 3:34 AM
gerritbot added a comment.Feb 3 2022, 4:34 PM

Change 141367 abandoned by Aklapper:

[mediawiki/extensions/WikiEditor@master] Link dialog: do basic URI validation

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiEditor/+/552359

https://gerrit.wikimedia.org/r/141367

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Feb 3 2022, 4:35 PM
Aklapper removed a subscriber: • wikibugs-l-list.
happy5214 added a comment.EditedFeb 7 2022, 6:44 AM

Appears to have been fixed in 6384498d as part of the OOUI conversion of the link insertion dialog.

Edit: It appears the code to fix this was added in that commit, but the example listed in the original bug report still fails.

gerritbot added a comment.Feb 7 2022, 7:07 AM

Change 552359 abandoned by Happy5214:

[mediawiki/extensions/WikiEditor@master] Link dialog: do basic URI validation

Reason:

Obsolete in light of OOUI rewrite of dialog.

https://gerrit.wikimedia.org/r/552359

happy5214 removed happy5214 as the assignee of this task.Feb 7 2022, 7:09 AM
happy5214 subscribed.
dom_walden subscribed.Feb 21 2022, 8:06 AM

Notes for testing:

  1. The validation logic will be different for an external link compared to an internal link. Test that the validation logic is still correct when you switching between internal and external in the dialog (and you should do this several times in a loop).
  2. Test the validation logic is correct when you highlight some wikitext and open the dialog (which will pre-populate the dialog). For example, at the moment, if I highlight [:<>] and open the dialog it is considered invalid. But, if I open the dialog without highlighting anything, switch to external and type :<> it is considered valid.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL