Page MenuHomePhabricator

DiscussionTools duplicates others comments when replying
Closed, DuplicatePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

2.PNG (869×1 px, 84 KB)

What happens?:
DiscussionTools duplicates others comments.
https://zh.wikipedia.beta.wmflabs.org/w/index.php?title=Wikipedia:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88/%E6%96%B9%E9%92%88&diff=19771&oldid=19770

3.PNG (807×1 px, 96 KB)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
On zhwiki 1.39.0-wmf.12 (036b6a4)
On zhwiki Beta Cluster 1.39.0-alpha (45b7945)

Event Timeline

Esanders subscribed.

The previous comment is definitely malformed (it has a {{tree start}} and {{tree end}} template split across two <dd> nodes). One for the parsing team.

This is a known issue with Parsoid, where editing pages that contain fostered content (*) will result in corrupted wikitext (T240280). The reply tool is supposed to prevent this by refusing to edit affected pages (T246481).

You can see this in action here: Talk:Fostered – if you click "reply", you'll just get an error message, because of the "fostered" error visible at Special:LintErrors?pagename=Talk:Fostered.

Apparently this doesn't work for Wikipedia:互助客栈/方针 – even though the page contains fostered content, there isn't a "fostered" error at Special:LintErrors?pagename=Wikipedia:互助客栈/方针.

(*) "Fostered content" is the name for some kinds of invalid HTML markup, e.g. text or markup directly inside a <table> node rather than inside a <td> node. This causes the parser to pull out the text or markup in front of the table, which is called "fostering". https://www.mediawiki.org/wiki/Help:Lint_errors/fostered