PHP Warning: array_key_exists() expects parameter 2 to be array, float given
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	thcipriani
	Jun 23 2022, 8:19 PM

Description

Error

mwversion: 1.39.0-wmf.17
reqId: 54588fb4-828b-428e-8f11-28b36874b7ef
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Warning: array_key_exists() expects parameter 2 to be array, float given

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.17/extensions/QuickSurveys/includes/SurveyFactory.php(77)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.39.0-wmf.17/extensions/QuickSurveys/includes/SurveyFactory.php(77): array_key_exists(string, double)
#2 /srv/mediawiki/php-1.39.0-wmf.17/extensions/QuickSurveys/includes/SurveyFactory.php(41): QuickSurveys\SurveyFactory->validateUniqueName(array, array)
#3 /srv/mediawiki/php-1.39.0-wmf.17/extensions/QuickSurveys/includes/ServiceWiring.php(29): QuickSurveys\SurveyFactory->parseSurveyConfig(array)
#4 /srv/mediawiki/php-1.39.0-wmf.17/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer::{closure}(MediaWiki\MediaWikiServices)
#5 /srv/mediawiki/php-1.39.0-wmf.17/vendor/wikimedia/services/src/ServiceContainer.php(416): Wikimedia\Services\ServiceContainer->createService(string)
#6 /srv/mediawiki/php-1.39.0-wmf.17/includes/MediaWikiServices.php(295): Wikimedia\Services\ServiceContainer->getService(string)
#7 /srv/mediawiki/php-1.39.0-wmf.17/extensions/QuickSurveys/includes/Hooks.php(47): MediaWiki\MediaWikiServices->getService(string)
#8 /srv/mediawiki/php-1.39.0-wmf.17/includes/HookContainer/HookContainer.php(338): QuickSurveys\Hooks::onBeforePageDisplay(OutputPage, MediaWiki\Skins\Vector\SkinVectorLegacy)
#9 /srv/mediawiki/php-1.39.0-wmf.17/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#10 /srv/mediawiki/php-1.39.0-wmf.17/includes/HookContainer/HookRunner.php(943): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#11 /srv/mediawiki/php-1.39.0-wmf.17/includes/OutputPage.php(2837): MediaWiki\HookContainer\HookRunner->onBeforePageDisplay(OutputPage, MediaWiki\Skins\Vector\SkinVectorLegacy)
#12 /srv/mediawiki/php-1.39.0-wmf.17/includes/MediaWiki.php(930): OutputPage->output(boolean)
#13 /srv/mediawiki/php-1.39.0-wmf.17/includes/MediaWiki.php(943): MediaWiki::{closure}()
#14 /srv/mediawiki/php-1.39.0-wmf.17/includes/MediaWiki.php(570): MediaWiki->main()
#15 /srv/mediawiki/php-1.39.0-wmf.17/index.php(50): MediaWiki->run()
#16 /srv/mediawiki/php-1.39.0-wmf.17/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}

Impact

Notes

Happened when we tried to roll out https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/808045

Details

Request URL: https://en.wikipedia.org/wiki/Special:BlankPage

	Subject	Repo	Branch	Lines +/-
	SurveyFactory: Log error when surveys configuration is not a list	mediawiki/extensions/QuickSurveys	master	+38 -0

Customize query in gerrit

Related Objects

Mentioned In: T311759: Deploy GDI Safety Survey Wave 2 on EN and FA wikis
T311434: [Reverted][2nd Attempt] - Deploy GDI Safety Survey Wave 2 on EN, ES, FA, FR, and PT wikis - PROD
T311429: UNDEPLOY - GDI Safety Survey Wave 2 on EN, ES, FA, FR, and PT wikis - BETA
Mentioned Here: rOMWCd08debf9dba2: Revert "[wmf-config]: Deploy GDI Safety Survey Wave 2"

Event Timeline

thcipriani created this task.Jun 23 2022, 8:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2022, 8:19 PM

thcipriani changed the subtype of this task from "Production Error" to "Bug Report".Jun 23 2022, 8:22 PM

Aklapper added a project: QuickSurveys.Jun 24 2022, 8:41 AM

Reedy added a project: Wikimedia-production-error.Jun 24 2022, 8:42 AM

• eigyan mentioned this in T311429: UNDEPLOY - GDI Safety Survey Wave 2 on EN, ES, FA, FR, and PT wikis - BETA.Jun 27 2022, 4:02 PM

• eigyan mentioned this in T311434: [Reverted][2nd Attempt] - Deploy GDI Safety Survey Wave 2 on EN, ES, FA, FR, and PT wikis - PROD.Jun 27 2022, 4:32 PM

We had more than a million of these in the last hour.

It seems like rOMWCd08debf9dba2: Revert "[wmf-config]: Deploy GDI Safety Survey Wave 2" wasn't completly synced?

https://sal.toolforge.org/log/fBjnqoEB8Fs0LHO5zKRW

@Zabe This ticket is really about noting the error that occurred during deployment - this change has already been reverted from production. We tried to deploy today and received the same error -> that change was also reverted. We make changes and will try again in the evening backport today.

thcipriani removed a project: Wikimedia-production-error.Jun 30 2022, 3:25 PM

TheresNoTime mentioned this in T311759: Deploy GDI Safety Survey Wave 2 on EN and FA wikis .Jun 30 2022, 6:00 PM

The issue was caused by misconfiguration. The patch linked in the description was setting $wgEnabledQuickSurveys to a single survey configuration (rather than a list of survey configurations) on ptwiki.

I would prefer to V:-2 configuration changes with invalid survey configuration but this is not possible AFAIK. The next best approach is to make QuickSurveys\SurveyFactory::parseSurveyConfig() resilient to this and to log a helpful error message.

Change 844447 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/QuickSurveys@master] SurveyFactory: Log error when surveys configuration is not a list

https://gerrit.wikimedia.org/r/844447

gerritbot added a project: Patch-For-Review.Oct 19 2022, 9:29 AM

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 9 2023, 8:14 PM

Change 844447 merged by jenkins-bot: