Page MenuHomePhabricator

RegexBlock's master branch does not pass CI
Closed, ResolvedPublic

Description

Proof: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/RegexBlock/+/811962

Build output: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/162311/console (marked as keep permanently)

Output copy:

21:19:12 ............PHP Fatal error:  Declaration of RegularExpressionDatabaseBlock::getIdentifier() must be compatible with MediaWiki\Block\DatabaseBlock::getIdentifier($wikiId = self::LOCAL) in /workspace/src/extensions/RegexBlock/includes/block/RegularExpressionDatabaseBlock.php on line 518
21:19:12 
21:19:12 Fatal error: Declaration of RegularExpressionDatabaseBlock::getIdentifier() must be compatible with MediaWiki\Block\DatabaseBlock::getIdentifier($wikiId = self::LOCAL) in /workspace/src/extensions/RegexBlock/includes/block/RegularExpressionDatabaseBlock.php on line 518
21:19:12 Script php tests/phpunit/phpunit.php handling the phpunit event returned with error code 255
21:19:12 Script @phpunit -c tests/phpunit/suite.xml was called via phpunit:entrypoint
21:19:12 INFO:quibble.commands:<<< Finish: PHPUnit extensions suite (without database or standalone), in 28.462 s