Page MenuHomePhabricator

Autopatrolled reviewer tagging a redirect as CSD should not autopatrol the resulting article
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create a redirect on testwiki with a non-admin account
  • Log into admin account on testwiki. There is no separate autopatrol right on testwiki, it is bundled with admin accounts.
  • Make sure Twinkle is installed
  • Make sure Twinkle's preference to mark CSD pages as patrolled is turned off
  • Tag the page with Twinkle CSD R3

What happens?:

  • Page is marked as reviewed

What should have happened instead?:

  • Page should not be marked as reviewed

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Can replace the Twinkle steps with PageTriage "deletion tagging" menu. Just tag it as CSD. Still reproducible.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

If the editor has autopatrol right, the edit will be patrolled, there isn't any way currently to prevent that. (See the PageUpdater::setRcPatrolStatus() call in EditPage.) RevisionFromEditComplete does not let you change the properties of the revision (other than the change tags). We'd have to add some mechanism to EditPage + ApiEdit to suppress the autopatrol right, or a custom hook for controlling autopatrol (there's a MarkPatrolled hook so I guess having a MarkAutoPatrolled would make sense). Or just accept that the revision gets created as patrolled and unpatrol it afterwards, but that seems like a very messy approach.