Page MenuHomePhabricator

[BUG] no-fallback message not showing
Closed, ResolvedPublicBUG REPORT

Description

when loading a ZObject with no available label, the no-fallbacks label is not appearing

Event Timeline

gengh renamed this task from should there be a fallback for English? to Decide what to do when a ZObject doesn't have a label in my language or any of its fallbacks (also no English).Aug 17 2022, 12:43 PM

We have the message wikilambda-multilingualstring-nofallback (English value: "No label defined in this language or accepted fallbacks ") which theoretically should be shown whenever we don't have any labels available. Should we show this here? It's a bit long.

Denny: Better to show some label than none. Select one from the language(s) available (first in the list?) and show that. Won't happen often.

Jdforrester-WMF renamed this task from Decide what to do when a ZObject doesn't have a label in my language or any of its fallbacks (also no English) to When a ZObject doesn't have a label in my language or any of its fallbacks (also no English), show the first label stored .Aug 30 2022, 6:46 PM
Jdforrester-WMF removed DVrandecic as the assignee of this task.
Jdforrester-WMF added a subscriber: DVrandecic.
Mahir256 renamed this task from When a ZObject doesn't have a label in my language or any of its fallbacks (also no English), show the first label stored to When a ZObject doesn't have a label in my language or any of its fallbacks (also no English), show the first label stored.Aug 30 2022, 9:08 PM

So I think there are actually two tasks here:

  1. [BUG] does not show no-fallback message when there are no labels in any fallback language
  2. [FEATURE] if there are labels that exist outside of the fallback chain (in this edge case, because english has no fallback chain, it is any non-english label when a user chooses english), should we show a label instead of the no-fallback message?

I've filed (2) as a separate task here because it is a pretty big change from how we treat language lookups now and probably merits discussion as to how best to do this.

JKieserman renamed this task from When a ZObject doesn't have a label in my language or any of its fallbacks (also no English), show the first label stored to [BUG] no-fallback message not showing.Sep 13 2022, 2:31 PM
JKieserman updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Bug Report". · View Herald TranscriptSep 13 2022, 2:31 PM

Change 831945 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] show 'Untitled' when there is no ZObject Label

https://gerrit.wikimedia.org/r/831945

Change 831945 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] show 'Untitled' when there is no ZObject Label

https://gerrit.wikimedia.org/r/831945