| Soda | |
| Oct 20 2022, 7:38 PM |
| F35607162: wikisource.png | |
| Oct 21 2022, 6:12 AM |
| F35605447: Screenshot_20221021-010146-143.png | |
| Oct 20 2022, 7:38 PM |
The WikiEditor UI and footer overlaps with the main text area on Wikisources in mobile mode when using the horizontal layout.
On initial inspection appears to be related to modules/page/ext.proofreadpage.page.edit.js:423 added in gerrit:821595.
Given that the peice of code has been in production for a bit, I wonder if some newer commit to WikiEditor/related module might be causing this weird interaction ?
On second thoughts, the code should probably probably set 'max-height' and not set a hardcoded height like it does now.
Change 845278 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):
[mediawiki/extensions/ProofreadPage@master] Fix floating footer and wikieditor UI issue.
Change 845278 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fix floating footer and wikieditor UI issue.
I've noticed a similar issue on desktop with the side by side view when a page is zoomed in.
Example screenshot from Chrome Canary (version 109) in Windows:
Steps to reproduce:
I think this is the same issue that I put in the patch for, I wasn't able to reproduce it on the fixed branch.
Change 845751 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):
[mediawiki/extensions/ProofreadPage@wmf/1.40.0-wmf.6] Fix floating footer and wikieditor UI issue.
Change 845751 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@wmf/1.40.0-wmf.6] Fix floating footer and wikieditor UI issue.