Page MenuHomePhabricator

Investigation: geopoint results seem to be inconsistent
Closed, ResolvedPublic

Description

Kartographer and Kartotherian are getting different results every time we run the geopoint query. Namely, * the points are different, and * the limit is not always respected, sometimes fewer are returned. Debug this issue and try to make the results consistent at least.

  • Run raw query against WDQS, disabling caching if possible. Is this where the variation is coming from? Is the point count varying?
    • The result ordering is arbitrary for any query without an explicit "order by".
    • I didn't see any evidence that the point count can vary. Kartotherian doesn't add its own limit, it passed the query through unchanged.
  • Does the query need an "order by" clause? If so, what is an appropriate ordering?
    • We can encourage a best practice of including ordering, by documenting in the help page. (diff) It's not really necessary, but might lead to less confusion if the static and live maps look consistent.