VisualEditor failing to load on interwiki redirect pages
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Krinkle
	Jan 3 2023, 7:49 PM

Description

Steps to replicate the issue (include links if applicable):

https://www.mediawiki.org/wiki/Performance_profiling_for_Wikimedia_code?veaction=edit

What happens?:

Page is stuck indefinitely loading.

Uncaught TypeError: linkData is null
  toDataElement @injectedScript
  createDataElements https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.core,mwtransclusion&skin=vector&version=1s8p8:251
  getDataFromDomSubtree https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.core,mwtransclusion&skin=vector&version=1s8p8:257
  getModelFromDom https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.core,mwtransclusion&skin=vector&version=1s8p8:252
  createModelFromDom @injectedScript
  createModelFromDom @injectedScript
  setupSurface

Other information (browser name/version, screenshots, etc.):

Firefox. macOS. Is affecting other redirect pages on mediawik.org as well, but only interwiki ones it seems. For example:

And several others.

Related Objects

Mentioned In: T326172: VE noscript fallback link on action=edit is inaccessible

Event Timeline

Krinkle created this task.Jan 3 2023, 7:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2023, 7:49 PM

Krinkle mentioned this in T326172: VE noscript fallback link on action=edit is inaccessible.Jan 3 2023, 8:00 PM

I don't think we've ever supported editing cross-wiki redirects (or realized that the feature exists).

The following VisualEditor patch appears to be sufficient to stop the visual editor from breaking, without any other cascading failure that I can see from a quick test:

diff --git a/modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js b/modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js
index 3d5d1a8bb..231f00c0a 100644
--- a/modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js
+++ b/modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js
@@ -35,7 +35,7 @@ ve.dm.MWRedirectMetaItem.static.matchRdfaTypes = [ 'mw:PageProp/redirect' ];
 ve.dm.MWRedirectMetaItem.static.toDataElement = function ( domElements, converter ) {
        // HACK piggy-back on MWInternalLinkAnnotation's ./ stripping logic
        var linkData = ve.dm.MWInternalLinkAnnotation.static.toDataElement( domElements, converter );
-       linkData.type = this.name;
+       if (linkData) linkData.type = this.name;
        return linkData;
 };

Of course, in addition to this we'd probably want to patch MW itself to hide the visual edit option and default to edit source, because all you get is an empty visual editor.

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Nov 30 2023, 4:57 PM

ppelberg removed a project: Editing-team.

VisualEditor failing to load on interwiki redirect pagesOpen, Needs TriagePublicBUG REPORTActions

Description

Related Objects

Event Timeline

VisualEditor failing to load on interwiki redirect pages
Open, Needs TriagePublicBUG REPORT
Actions