Page MenuHomePhabricator
Create Task
Maniphest T327964

[wmf.20] mobile Special:Preferences section pages display "Cannot read properties of undefined (reading 'scrollIntoView')"
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. On mobile login to testwiki wmf.20 (or enwiki betalabs) and click on Settings to get to the Special:Preferences page.
  2. If Advanced mode is enabled, click on Open preferences link under User preferences:

Screen Shot 2023-01-25 at 2.16.45 PM.png (1×808 px, 155 KB)

  1. The page Special:Preferences will be displayed.
  2. Click on any of the group of preferences, e.g. User profile

The following Console error will be displayed:
Uncaught TypeError: Cannot read properties of undefined (reading 'scrollIntoView')

Note:

  • the error is displayed in betacluster and in testwiki wmf.20. The error is not present in wmf.19.

Details

SubjectRepoBranchLines +/-
Special:Preferences fix production JS errormediawiki/coremaster+9 -5
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 25 2023, 10:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2023, 10:26 PM
Jdlrobson edited projects, added MediaWiki-Core-Preferences, Moderator-Tools-Team, Wikimedia-production-error; removed Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 3).EditedJan 30 2023, 4:20 PM

This doesn't seem to relate to web team work. I've added the more appropriate team.

This happens on both mobile and desktop site and is significant enough to appear in production error logs e.g. Find reqId in Logstash

351 errors in the last 12 hours.
https://gerrit.wikimedia.org/g/mediawiki/core/+/24bbce386cd6ecd79cbb72dc9b699499480d160f/resources/src/mediawiki.special.preferences.ooui/mobile.js#17

• Samwalton9-WMF added subscribers: jsn.sherman, • Samwalton9-WMF.Jan 30 2023, 4:26 PM

Possibly introduced in T321330: Fix anchored links in new mobile preferences design - @jsn.sherman

jsn.sherman claimed this task.Jan 30 2023, 4:36 PM

Investigating now

jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.Jan 30 2023, 4:36 PM
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Jan 30 2023, 4:55 PM

Change 884963 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/core@master] Special:Preferences fix production JS error

https://gerrit.wikimedia.org/r/884963

gerritbot added a project: Patch-For-Review.Jan 30 2023, 4:55 PM
jsn.sherman moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.EditedJan 30 2023, 5:00 PM

I ommited a guard clause in the mobile layout that I added in the tabbed layout; the attached patch prevents the error.

PatchDemoBot added a comment.Jan 30 2023, 5:03 PM

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a974a7c002/w

Aklapper renamed this task from [wmf.20] mobile Special:Preferences section paages display "Cannot read properties of undefined (reading 'scrollIntoView')" to [wmf.20] mobile Special:Preferences section pages display "Cannot read properties of undefined (reading 'scrollIntoView')".Jan 30 2023, 5:22 PM
Umherirrender added a project: JavaScript.Jan 30 2023, 9:05 PM
gerritbot added a comment.Jan 30 2023, 10:43 PM

Change 884963 merged by jenkins-bot:

[mediawiki/core@master] Special:Preferences fix production JS error

https://gerrit.wikimedia.org/r/884963

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 30 2023, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 30 2023, 11:30 PM
Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Jan 31 2023, 2:58 AM
• Samwalton9-WMF closed this task as Resolved.Feb 7 2023, 3:41 PM

Not seeing any console errors in production now.

PatchDemoBot added a comment.Jun 30 2023, 2:09 PM

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/a974a7c002/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL