Page MenuHomePhabricator

In the Main page of Konkani Wikipedia the sticky header is not tall enough for two lines (Vector 2022)
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • log-in on Konkani Wikipedia (gom.wikipedia)
  • look at the Welcome message in the header: there are two lines because of two scripts
  • then, scroll down and look at the the sticky header

What happens?:

  • the sticky header is not tall enough for two lines, double Welcome message doesn't fit

What should have happened instead?:

  • the sticky header should adapt to long text/two lines text, on local wiki CSS or by design

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
originally reported on MediaWiki, DI talk

Screenshot 2023-02-25 at 13-38-53 विकिपीडिया.png (1×2 px, 451 KB)

Screenshot 2023-02-25 at 13-39-59 विकिपीडिया.png (1×2 px, 472 KB)

Event Timeline

In the original message:

It only happens on the main page, because the main page is the only one that is explicitly formatted to be on two lines. On all other pages the headings are shortened using ellipses (...) and do not wrap

I am not qualified to suggest a solution, but:

  • 1. the text should be shorter and in one line: विकिपीडियांत येवकार तुका, Wikipidiant yeukar tuka, _user_name_!
  • 2 when vector-sticky-header height: 3.125rem; is disabled the text fits the sticky header, or max-height: 4.1rem; should work too

If I were to fix it in the local CSS, I would reduce vector-sticky-header-context-bar-primary font-size: 1.5em; to 1.3em (slightly bigger than h3) and increase vector-sticky-header height: 3.125rem; to 3.725rem.

But the bigger question here is whether the developers would like to, or should, make the skin be able to adjust to two-line headers by itself.

ovasileva triaged this task as Medium priority.Mar 1 2023, 10:55 PM
ovasileva moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.

I just noticed that this issue has been fixed. Thank you, and feel free to close this task as resolved.

ovasileva claimed this task.
ovasileva subscribed.

Seems like this is fixed so resolving for now. Will open again if there's reports of this issue from other wikis