Page MenuHomePhabricator

[frontend][homepage]Remove submitted task from task list
Closed, ResolvedPublic

Description

Currently, once a task is submitted it remains available on the homepage. Instead, upon a successful "submit" that task should be removed from the array of offered tasks and a new one rendered.

Event Timeline

Slst2020 triaged this task as High priority.Mar 6 2023, 1:44 PM
Slst2020 removed projects: Epic, User-Slst2020.
NicoleLBee changed the task status from Open to In Progress.Mar 8 2023, 8:30 AM
NicoleLBee claimed this task.
NicoleLBee moved this task from Backlog to In review on the Toolhunt board.

I've opened a PR to address this issue: https://github.com/wikimedia/toolhunt-ui/pull/41

Upon a "successful" task submission (e.g., one that does not return an error on the front end), the submitted task will be removed from the task array and a new one will be presented.

I did make a pretty significant change to the Homepage structure: as I needed to emit directly from UserContributionForm to Homeview, I stripped out the Home.vue component entirely and moved its contents to HomeView.vue.

An alternative would be to restore Home.vue, but as a sibling component to the UserContributionForm, rather than having a chained set of child components. (That's why I've left Home.vue in the file system rather than removing it.)

I went back on my decision to remove Home.vue and merely refactored it so that it and UserContributionForm are both children of HomeView.vue.

Unfortunately the tests for Home.vue REALLY didn't like that, so I had to make some significant changes. Ideally I'll like to write a test that would start from HomeView and test the entire throughput, but we're coming down to the wire now and I don't have enough time.

I've downgraded my PR to draft. Considering the many changes that have been made to the frontend and the ongoing warning messages that I've still not been able to fix, this PR requires a lot of work before it's ready to deploy.

If anyone else would like to take a stab at the problem, or rework my code if you don't want to start from scratch, feel free.

NicoleLBee claimed this task.