Page MenuHomePhabricator

Fatal error on "Special:ManageMessageGroups/mediawiki"
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

https://translatewiki.net/wiki/Special:ManageMessageGroups/mediawiki

From IRC channel:
[2023-06-08T19:52:25.665250+00:00] exception.ERROR: [1adb973dd1d13ab09a534631] /wiki/Special:ManageMessageGroups/mediawiki Error: Call to a member function getContent() on null {"exception":"[object] (Error(code: 0): Call to a member function getContent() on null at /srv/mediawiki/tags/2023-06-07_16:09:45/extensions/Translate/src/Synchronization/ManageGroupsSpecialPage.php:348)

Event Timeline

Raymond triaged this task as High priority.Jun 8 2023, 7:59 PM
Raymond added subscribers: Nikerabbit, abi_.

Change 928696 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ManageGroupsSpecialPage: Check revision before fetching content

https://gerrit.wikimedia.org/r/928696

abi_ set the point value for this task to 1.Jun 9 2023, 4:03 AM

Change 928696 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ManageGroupsSpecialPage: Check revision before fetching content

https://gerrit.wikimedia.org/r/928696

Change 928789 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslationsSpecialPage: Add null check for convertWhiteSpaceToHTML

https://gerrit.wikimedia.org/r/928789

The error was primarily being caused by the following message: https://translatewiki.net/w/i.php?title=Special:Translate&showMessage=wikimedia-discussiontools-replywidget-terms-click&group=ext-wikimediaoverrides&language=fi&filter=&optional=1&action=translate which seems to have no revision associated with it for some reason. I'm wondering if this is related to the revision_temp > revision table migration that happened recently.

To reduce the logspam, I had to take the translation and add it to the Finnish translation via Special:Translate. See change: https://translatewiki.net/w/i.php?title=MediaWiki:Wikimedia-discussiontools-replywidget-terms-click/fi&oldid=11645691

The script: maintenance/deleteOrphanedRevisions.php reported that there are 2908 orphaned revision. Not sure if this is somehow related.

Change 928789 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] TranslationsSpecialPage: Add null check for convertWhiteSpaceToHTML

Reason:

Not needed

https://gerrit.wikimedia.org/r/928789