Page MenuHomePhabricator

Discussion tool saved answer not accessible on mobile when multiple pages are included
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?: When you leave an unfinished comment on mobile and go back, the section of the day gets locked and you cannot expand it anymore + you keep seeing your screen moving you to this section although you cannot edit it nor cancel the message.

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.): Opera mobile

Event Timeline

Esanders subscribed.

Subtly different from T333872

Change 930227 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Set URL fragment when recovering auto-save on mobile

https://gerrit.wikimedia.org/r/930227

With the patch, the comment you're replying to is now highlighted in blue (like the target comment when following a notification). This isn't great, but it's not a big deal, and it might be tricky to avoid that.

Change 930227 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Set URL fragment when recovering auto-save on mobile

https://gerrit.wikimedia.org/r/930227

matmarex removed a project: Editing QA.
matmarex added a subscriber: Ryasmeen.

@Ryasmeen reports that this didn't work.

I just checked this on iOS 16.0.3, when I leave the page with an unfinished comment and reload the tab, all the other sections are opening except the one where the previous comment was retrieved. Here is a screen capture of that:

I can also reproduce. Note that you have to be using a phone-sized device (where all sections are collapsed by default), and you have to close the tab and open it again instead of just refreshing.

This has been happening to me on the English Wikipedia. I use Firefox on Android. This started happening a few days ago. I will post here what I posted on the Village Pump.

The reply tool is doing some rather dumb and bad stuff and I do not know how to fix it. I'm using the mobile website (the app, while nice for reading, is more or less unusable for editing and administrative tasks) on Android. The issue is with saved comments. If the reply tool has a saved partial comment, it will disable itself for any other comment on the page. Fine. But it will also gray out the expand button for the section it's in! It's impossible, then, to access the comment I have saved, or even to read the section it's in. It's also impossible to discard the comment so that the page works normally. The only way to fix it is to switch to the desktop display, then edit the URL to be the desktop URL, then scroll down to the section and cancel the reply, then go back to the mobile version and it will work again. It's also possible to just edit the page to change the section title, but this is extremely stupid and also destroys the comment.

Noting for the sake of this bug report that what jpxg describes has also been happening to me (Safari on iOS). The only thing I’ve noticed that sometimes fixes it is repeatedly refreshing the page - which sometimes results in the section expanding correctly after one of the refreshes.

Change 995733 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix collapsed sections when recovering autosave on mobile, take 2

https://gerrit.wikimedia.org/r/995733

Change 995733 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix collapsed sections when recovering autosave on mobile, take 2

https://gerrit.wikimedia.org/r/995733

@matmarex: I re-checked this one on fr.wiki, and it seems to be still happening, the section with unfinished comment is still not expanding and stays inaccessible.

Hm, it works for me on desktop Chromium, so I thought it was fixed, but it doesn't work on desktop Firefox and on mobile Safari.

Change 1005860 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix collapsed sections when recovering autosave on mobile, take 3

https://gerrit.wikimedia.org/r/1005860

This time it'll really work. I hope :) Sorry about that.

Change 1005860 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix collapsed sections when recovering autosave on mobile, take 3

https://gerrit.wikimedia.org/r/1005860

Ryasmeen claimed this task.
Ryasmeen edited projects, added Verified; removed Editing QA.