Page MenuHomePhabricator
Create Task
Maniphest T343155

Phan is failing on CI with errors related to ParserOutput and ParsoidParser
Closed, ResolvedPublic
Actions

Description

Phan error log

20:05:57 includes/parser/ParserOutput.php:2443 UnusedPluginSuppression Plugin BuiltinSuppressionPlugin suppresses issue PhanUndeclaredMethod on this line but this suppression is unused or suppressed elsewhere
20:05:57 includes/parser/Parsoid/ParsoidParser.php:166 UnusedPluginSuppression Plugin BuiltinSuppressionPlugin suppresses issue PhanUndeclaredStaticMethod on this line but this suppression is unused or suppressed elsewhere

Impact

Seems to be affecting all patches on Gerrit (?)

Details

SubjectRepoBranchLines +/-
Remove Parsoid back-compat codemediawiki/coremaster+9 -22
parser: Remove phan-suppression after parsoid 0.18.0-a20 updatemediawiki/coremaster+1 -3
Customize query in gerrit

Event Timeline

DAlangi_WMF created this task.Jul 31 2023, 7:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2023, 7:19 PM
DAlangi_WMF added a project: ci-test-error.Jul 31 2023, 7:20 PM
DAlangi_WMF updated the task description. (Show Details)
DAlangi_WMF added a project: phan.
gerritbot added a comment.Jul 31 2023, 8:01 PM

Change 943634 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] parser: Remove phan-suppression after parsoid 0.18.0-a20 update

https://gerrit.wikimedia.org/r/943634

gerritbot added a project: Patch-For-Review.Jul 31 2023, 8:01 PM
Umherirrender subscribed.Jul 31 2023, 8:02 PM

Parsoid was updated - https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/943619

Affects all core patches for normal test and gate-and-submit

Umherirrender triaged this task as Unbreak Now! priority.Jul 31 2023, 8:13 PM
cscott closed this task as Resolved.Jul 31 2023, 10:11 PM
cscott claimed this task.
cscott subscribed.

Patch merged. Sorry about that. I wish I knew of a way to make phan happy with a backcompat patch both before and after the dependency is updated.

gerritbot added a comment.Jul 31 2023, 10:11 PM

Change 943640 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Remove Parsoid back-compat code

https://gerrit.wikimedia.org/r/943640

gerritbot added a comment.Jul 31 2023, 10:21 PM

Change 943634 merged by jenkins-bot:

[mediawiki/core@master] parser: Remove phan-suppression after parsoid 0.18.0-a20 update

https://gerrit.wikimedia.org/r/943634

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 31 2023, 11:00 PM
gerritbot added a comment.Aug 1 2023, 2:24 PM

Change 943640 merged by jenkins-bot:

[mediawiki/core@master] Remove Parsoid back-compat code

https://gerrit.wikimedia.org/r/943640

Maintenance_bot removed a project: Patch-For-Review.Aug 1 2023, 2:30 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 1 2023, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL