Page MenuHomePhabricator
Create Task
Maniphest T344540

Wrong admin name is passed to message Growthexperiments-quit-mentorship-reassign-mentees-log-message-removed
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The reason is "Gaolezhe將Gaolezhe從導師計畫中移除。"
Raw message: "$2將$1從導師計畫中移除。"
https://translatewiki.net/w/i.php?title=MediaWiki:Growthexperiments-quit-mentorship-reassign-mentees-log-message-removed/zh-hant

What should have happened instead?:
The correct reason is "Xiplus將Gaolezhe從導師計畫中移除。"

Details

SubjectRepoBranchLines +/-
MentorRemover: Pass correct usernamemediawiki/extensions/GrowthExperimentsmaster+1 -1
Customize query in gerrit

Event Timeline

Xiplus created this task.Aug 19 2023, 6:38 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 19 2023, 6:38 AM
Restricted Application added subscribers: Stang, Aklapper. · View Herald Transcript
gerritbot added a comment.Aug 20 2023, 8:20 PM

Change 950831 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorRemover: Pass correct username

https://gerrit.wikimedia.org/r/950831

gerritbot added a project: Patch-For-Review.Aug 20 2023, 8:20 PM
Urbanecm_WMF claimed this task.Aug 20 2023, 8:39 PM
Urbanecm_WMF triaged this task as High priority.
Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), GrowthExperiments-MentorDashboard; removed Patch-For-Review, Growth-Team.
Urbanecm_WMF subscribed.

Thanks for reporting! I uploaded a fix for this issue.

Urbanecm_WMF added a project: Patch-For-Review.Aug 20 2023, 8:39 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Aug 20 2023, 9:15 PM
gerritbot added a comment.Aug 21 2023, 12:15 PM

Change 950831 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorRemover: Pass correct username

https://gerrit.wikimedia.org/r/950831

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 21 2023, 12:33 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 21 2023, 2:27 PM
Etonkovidova subscribed.

Checked in beta (e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Log&logid=392990) - works as expected.

Testing note: when testing on production, compare with the previous (incorrect) message (e.g. https://test.wikipedia.org/w/index.php?title=Special:Log&logid=365239)

Etonkovidova added a comment.Aug 25 2023, 9:00 PM

Checked on testwiki wmf.23 - the fix is in place:

before the fix https://test.wikipedia.org/w/index.php?title=Special:Log&logid=365239after the fix (wmf.23) https://test.wikipedia.org/w/index.php?title=Special:Log&logid=365317
Screen Shot 2023-08-25 at 2.00.29 PM.png (106×2 px, 66 KB)
Screen Shot 2023-08-25 at 1.57.45 PM.png (66×2 px, 60 KB)
Etonkovidova closed this task as Resolved.Aug 25 2023, 9:01 PM
Etonkovidova removed a project: Patch-For-Review.
Stang unsubscribed.Aug 28 2023, 10:33 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 11:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL