Page MenuHomePhabricator
Create Task
Maniphest T347418

The visual editor broke a link while apparently trying to normalize it
Closed, ResolvedPublicBUG REPORT
Actions

Description

See https://office.wikimedia.org/w/index.php?diff=prev&oldid=339513

I don't think I even clicked on the lines that were changed. One of them was obviously broken, and the other was just fiddled with unnecessarily. The broken one changed:

* [[w:en:Wikipedia:Village pump (policy)]]

into

* [w:en:Wikipedia:Village pump (policy) w:en:Wikipedia:Village pump (policy)]

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.18.0-a26mediawiki/vendormaster+542 -1 K
Strip fragment when checking for ? when serializing interwiki targetmediawiki/services/parsoidmaster+27 -8
Customize query in gerrit

Event Timeline

• Whatamidoing-WMF created this task.Sep 26 2023, 5:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2023, 5:32 PM
ssastry added a project: Parsoid.Sep 26 2023, 5:44 PM
Arlolra claimed this task.Sep 26 2023, 6:36 PM
Arlolra triaged this task as Medium priority.
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
Arlolra subscribed.

It looks like the question mark is forcing this as an extlink,

> echo "[[w:en:Wikipedia:Village pump (policy)/Archive 183#Request for Comment: Should editing on Wikipedia be limited to accounts only?]]" | php bin/parse.php --wt2wt --domain www.mediawiki.org
[w:en:Wikipedia:Village pump (policy)/Archive 183#Request for Comment: Should editing on Wikipedia be limited to accounts only? w:en:Wikipedia:Village pump (policy)/Archive 183#Request for Comment: Should editing on Wikipedia be limited to accounts only?]

> echo "[[w:en:Wikipedia:Village pump (policy)/Archive 183#Request for Comment: Should editing on Wikipedia be limited to accounts only]]" | php bin/parse.php --wt2wt --domain www.mediawiki.org 
[[w:en:Wikipedia:Village pump (policy)/Archive 183#Request for Comment: Should editing on Wikipedia be limited to accounts only]]

Probably just needs to recognize that it's in the fragment.

gerritbot added a comment.Sep 26 2023, 9:23 PM

Change 961244 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Strip fragment when checking for ? when serializing interwiki target

https://gerrit.wikimedia.org/r/961244

gerritbot added a project: Patch-For-Review.Sep 26 2023, 9:23 PM
Arlolra added projects: Content-Transform-Team-WIP, Essential-Work.Sep 26 2023, 9:23 PM
Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.
Arlolra moved this task from In Progress to To Deploy on the Content-Transform-Team-WIP board.Sep 27 2023, 5:54 PM
gerritbot added a comment.Sep 27 2023, 6:01 PM

Change 961244 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Strip fragment when checking for ? when serializing interwiki target

https://gerrit.wikimedia.org/r/961244

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2023, 6:10 PM
gerritbot added a comment.Oct 2 2023, 9:11 PM

Change 962706 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

gerritbot added a project: Patch-For-Review.Oct 2 2023, 9:11 PM
gerritbot added a comment.Oct 2 2023, 10:28 PM

Change 962706 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.18.0-a26

https://gerrit.wikimedia.org/r/962706

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 10:31 PM
Arlolra moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Oct 3 2023, 10:20 PM
Arlolra closed this task as Resolved.Oct 3 2023, 10:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL