MultimediaViewer no longer usable on Special:ListFiles (for $wgParserEnableLegacyMediaDOM = false)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Umherirrender
	Oct 5 2023, 7:16 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://www.mediawiki.org/wiki/Special:ListFiles
Click a thumb

What happens?:
The file description page is loaded

What should have happened instead?:
MultimediaViewer should show the original file

The modules are loaded on the page. It seems MultimediaViewer is looking for a.image img in the html dom, but since fdd8f864 the class is no longer outputted when $wgParserEnableLegacyMediaDOM is false. The setting is false on wmf wikis since 76400482 It works locally with true for that setting.

Software version (skip for WMF-hosted wikis like Wikipedia): master

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	Skip thumbs from a.mw-file-description with typeof attribute	mediawiki/extensions/MultimediaViewer	master	+10 -0
	Use a.mw-file-description to find thumbs	mediawiki/extensions/MultimediaViewer	master	+3 -2

Customize query in gerrit

Related Objects

Mentioned In: T349448: MediaViewer displays each image twice when using left/right navigation
Mentioned Here: rMW892781fe9407: Change the default of wgParserEnableLegacyMediaDOM to false
rMW5dfe24b03a79: Change the default of wgParserEnableLegacyMediaDOM to false
rMWfdd8f864b84d: Emit media structure as piloted in Parsoid
rOMWC764004824288: Disable wgParserEnableLegacyMediaDOM on group2 wikis

Event Timeline

Umherirrender created this task.Oct 5 2023, 7:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2023, 7:16 PM

Change 963802 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MultimediaViewer@master] Use a.mw-file-description to find thumbs

https://gerrit.wikimedia.org/r/963802

gerritbot added a project: Patch-For-Review.Oct 5 2023, 7:16 PM

The default of that config was changed to false in 1.41 (892781fe), but also backported to 1.40 (5dfe24b0), so third wikis could be affected as well.

Change 963802 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use a.mw-file-description to find thumbs

https://gerrit.wikimedia.org/r/963802

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2023, 2:10 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 12 2023, 3:00 AM

Umherirrender closed this task as Resolved.Oct 12 2023, 7:43 PM

Umherirrender claimed this task.

Pols12 mentioned this in T349448: MediaViewer displays each image twice when using left/right navigation.Oct 28 2023, 2:13 PM

Change 971279 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MultimediaViewer@master] Improve a.mw-file-description selector for special pages

https://gerrit.wikimedia.org/r/971279

gerritbot added a project: Patch-For-Review.Nov 2 2023, 7:45 PM

Change 971279 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Skip thumbs from a.mw-file-description with typeof attribute