Page MenuHomePhabricator
Create Task
Maniphest T353249

De-duplicate Less_Tree_Color::fromKeyword method
Closed, ResolvedPublic
Actions

Description

During https://gerrit.wikimedia.org/r/c/mediawiki/libs/less.php/+/981308/ we found that the fromKeyword function is duplicated for unclear reasons.

I suggest we:

  1. Find when it was duplicated (git blame).
  2. If no compelling reason is apparent from that change, then remove the Less_Parser method and call the public Less_Tree_Color::fromKeyword in both places instead. We prefer this version, because that matches where it is defined in less-2.5.3.js.

Details

SubjectRepoBranchLines +/-
Less_Parser: De-duplicate Less_Tree_Color::fromKeyword methodmediawiki/libs/less.phpmaster+1 -20
Customize query in gerrit

Event Timeline

Krinkle created this task.Dec 12 2023, 12:35 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptDec 12 2023, 12:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
pmiazga moved this task from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.Dec 12 2023, 3:50 PM
Hokwelum moved this task from Soon to Current Sprint on the MediaWiki-Platform-Team board.Jan 4 2024, 9:01 PM
gerritbot added a comment.Jan 4 2024, 9:03 PM

Change 987824 had a related patch set uploaded (by Hokwelum; author: Hokwelum):

[mediawiki/libs/less.php@master] De-duplicate Less_Tree_Color::fromKeyword method

https://gerrit.wikimedia.org/r/987824

gerritbot added a project: Patch-For-Review.Jan 4 2024, 9:03 PM
Hokwelum added a comment.Jan 4 2024, 9:16 PM

This patch added the duplicate. Right now, there's no need for the duplicate function since we no longer use the old cache method which was removed Here.

Krinkle triaged this task as Low priority.Jan 5 2024, 2:21 PM
Krinkle closed this task as Resolved.Jan 5 2024, 2:52 PM
gerritbot added a comment.Jan 5 2024, 2:52 PM

Change 987824 merged by jenkins-bot:

[mediawiki/libs/less.php@master] Less_Parser: De-duplicate Less_Tree_Color::fromKeyword method

https://gerrit.wikimedia.org/r/987824

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2024, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL