Add param id check for customField getFieldOptions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	AnnWF
	Dec 22 2023, 2:05 AM

Description

Caused by some civi report:
can see the log from frlog1002:/var/log/remote by grep getFieldOptions *

TypeError: Argument 1 passed to CRM_Core_BAO_CustomField::getFieldOptions() must be of the type int, null given, called in /srv/org.wikimedia.civicrm/drupal/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php on line 808 in CRM_Core_BAO_CustomField::getFieldOptions() (line 2978 of /srv/org.wikimedia.civicrm/drupal/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php).

need civi upstream update

Details

	Subject	Repo	Branch	Lines +/-
	Add param check before get options from cache	wikimedia/fundraising/crm	master	+3 -1
	Pull in latest extended reports	wikimedia/fundraising/crm	master	+5 -5

Customize query in gerrit

Related Objects

Mentioned In: T354308: Migrate extended report to search kit

Event Timeline

AnnWF created this task.Dec 22 2023, 2:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2023, 2:05 AM

AnnWF updated the task description. (Show Details)Dec 22 2023, 2:10 AM

upstream:
https://github.com/civicrm/civicrm-core/pull/28777
Once merged upstream, will then update locally

Change 985071 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/crm@master] Add param check before get options from cache

https://gerrit.wikimedia.org/r/985071

gerritbot added a project: Patch-For-Review.Dec 22 2023, 2:32 AM

AnnWF claimed this task.Dec 22 2023, 2:33 AM

AnnWF moved this task from Backlog to Ready for Review on the Fundraising Tech - Chaos Crew board.

I took a quick peek at the code & it looks like id *shoud* be populated when it gets to that point which makes me wonder if the error is the symptom, not the cause - do we have any more info about how this error arises? I'm not sure if we should be quietly ignoring (per the patch) or possibly throwing an exception when that condition occurs

AnnWF updated the task description. (Show Details)Jan 3 2024, 8:41 PM

Change 987497 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Pull in latest extended reports

https://gerrit.wikimedia.org/r/987497

Eileenmcnaughton mentioned this in T354308: Migrate extended report to search kit.Jan 3 2024, 10:48 PM

Change 987497 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Pull in latest extended reports

https://gerrit.wikimedia.org/r/987497

greg triaged this task as Medium priority.Jan 5 2024, 5:11 PM

Change 985071 abandoned by Wfan:

[wikimedia/fundraising/crm@master] Add param check before get options from cache

Reason: