Page MenuHomePhabricator

Migrate usage of Database::update to UpdateQueryBuilder in ReadingLists
Closed, ResolvedPublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::update() to UpdateQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

Assuming this task is about the MediaWiki-extensions-ReadingList code project, hence adding that project tag so other people can also find this task when searching via tasks related to projects. Please set appropriate project tags when possible. Thanks!

Change 990941 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/ReadingLists@master] Migrate update and delete to query builders

https://gerrit.wikimedia.org/r/990941

Change 990941 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Migrate update, delete and insert to query builders

https://gerrit.wikimedia.org/r/990941

Atieno claimed this task.