Page MenuHomePhabricator

Fix refinery-source.refinery-core.Utilities::getValueForKey
Closed, ResolvedPublic

Description

The method finds a value for a key in a map-formatted string of format k1=v1;k2=v2... but has a bug when a key is a substring of another one, for instance looking for key preview in the string ...;chrome_preview=...;

Event Timeline

JAllemandou triaged this task as Unbreak Now! priority.Jan 19 2024, 8:18 AM

Change 991563 had a related patch set uploaded (by Btullis; author: Btullis):

[operations/puppet@production] Revert "varnish: enrich X-Analytics for browser prefetch / prerender / preview"

https://gerrit.wikimedia.org/r/991563

This issue was discovered shortly after this patch was deployed: https://gerrit.wikimedia.org/r/c/operations/puppet/+/981352
It relates to this task: T346463: Identify and label prefetch proxy data in our traffic

We have decided to revert the change to varnish whilst we work on fixing the refinery code.

Change 991563 merged by Btullis:

[operations/puppet@production] Revert "varnish: enrich X-Analytics for browser prefetch / prerender / preview"

https://gerrit.wikimedia.org/r/991563

The change that uncovered this behaviour in refinery has been temporarily reverted, so we should not receive any more of these for the time being.

Change 992475 had a related patch set uploaded (by Aqu; author: Aqu):

[analytics/refinery/source@master] [WIP] Use str_to_map built-in fct to parse x-analytics-header

https://gerrit.wikimedia.org/r/992475

Change 992477 had a related patch set uploaded (by Aqu; author: Aqu):

[analytics/refinery@master] [WIP] Use str_to_map built-in fct to parse x-analytics-header

https://gerrit.wikimedia.org/r/992477

Change 992475 merged by jenkins-bot:

[analytics/refinery/source@master] Adopt a more resilient approach to use webrequest x-analytics

https://gerrit.wikimedia.org/r/992475

Change 992477 merged by Aqu:

[analytics/refinery@master] Adopt a more resilient approach to use webrequest x-analytics

https://gerrit.wikimedia.org/r/992477

Change 992752 had a related patch set uploaded (by Aqu; author: Aqu):

[analytics/refinery/source@master] Fix null pointer error in isPageviewUdf

https://gerrit.wikimedia.org/r/992752

Change 992752 merged by Aqu:

[analytics/refinery/source@master] Fix null pointer error in isPageviewUdf

https://gerrit.wikimedia.org/r/992752