VisualEditor - Editing mode not active after pressing the Edit button.
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Fspitzer
	Jan 26 2024, 2:36 PM

Description

Hi,
I am running MediaWiki via the official docker environment for two years now.

MediaWiki Version is: 1.41.0
VisualEditor Version: 0.1.2
Theme: Vector 2022

Since one of the last updates the VisualEditor is not working correctly anymore. If I klick on the Edit Button of inside a page the following happens:

the Editor starts (progrss bar is shortly visable)
All edit functions show up but the buttons are all greyed out (the only active buttons are help, page options, and change editor). In addition all page content is grey out and not selectable (see screenshot)
I am not able to edit anything except when changing to edit the Source code
The browser development console contains the following error:

Widget.js:45 Uncaught TypeError: Cannot read properties of undefined (reading 'connect')

at new VeUiMWTocWidget (ve.ui.MWTocWidget.js:45:16)
at ve.init.mw.DesktopArticleTarget.surfaceReady (ve.init.mw.DesktopArticleTarget.js:753:25)
at eval (ve.init.mw.Target.js:410:10)

This happens for all users and in all tested browsers (Edge, Brave and Firefox).

Any idea what's going wrong?

Thanks
Fritz

Details

	Subject	Repo	Branch	Lines +/-
	MWTocWidget should fetch the metaList from the correct location	mediawiki/extensions/VisualEditor	REL1_41	+1 -1
	MWTocWidget should fetch the metaList from the correct location	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rEVEDe8fb5d8442e2: Localisation updates from https://translatewiki.net.

Event Timeline

Fspitzer created this task.Jan 26 2024, 2:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2024, 2:36 PM

Looks like https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/755394 didn't update MwTocWidget for the metalist change. We didn't notice this, because it's disabled by default (and not enabled on any WMF wikis).

DLynch moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.Jan 26 2024, 4:24 PM

Change 993158 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] MWTocWidget should fetch the metaList from the correct location

https://gerrit.wikimedia.org/r/993158

gerritbot added a project: Patch-For-Review.Jan 26 2024, 4:27 PM

DLynch moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Jan 26 2024, 4:27 PM

@Fspitzer in the interim, if you adjust your LocalSettings.php to disable $wgVisualEditorEnableTocWidget this should stop happening.

Change 993158 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MWTocWidget should fetch the metaList from the correct location

https://gerrit.wikimedia.org/r/993158

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Jan 26 2024, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2024, 6:30 PM

Skipping QA because this can't be tested on WMF beta/production.

@DLynch
Thanks for your fast response, David!
I just have disabled the TocWidget as recommended. Now the VisualEditor works fine again.

Cheers
Fritz

Esanders closed this task as Resolved.Feb 8 2024, 12:05 PM

Change 1008006 had a related patch set uploaded (by Lens0021; author: DLynch):

[mediawiki/extensions/VisualEditor@REL1_41] MWTocWidget should fetch the metaList from the correct location

https://gerrit.wikimedia.org/r/1008006

gerritbot added a project: Patch-For-Review.Mar 2 2024, 3:11 AM

This still happens in REL1_41(e8fb5d8442e24db098fb4de6d13bb9f037a0b824).

Change 1008006 merged by jenkins-bot: