Page MenuHomePhabricator

Allow users to alter the sidebar
Open, Needs TriagePublic

Description

(Imported from GitHub issues)


addshore:
{F41817964}

Currently these are unset https://github.com/wbstack/mediawiki/blob/main/wbstack/src/Settings/LocalSettings.php#L249-L255

The reasoning behind this was to turn off some things which allow "great flexibility" and turn them on in a controlled way when use cases surfaced.

We probably want to turn on interface message editing, but avoid CSS / JS editing for now?

GreenReaper:
Bureaucrats can at least still edit CSS and JSON. The former, at least. I think the latter are used for certain extension or tools settings? Not sure if

addshore:

Bureaucrats can at least still edit CSS and JSON. The former, at least.

Indeed https://github.com/wbstack/mediawiki/blob/main/wbstack/src/Settings/LocalSettings.php#L258

I think the latter are used for certain extension or tools settings? Not sure if

Yeah, it can be used by any number of things, extensions tools etc.

editinterface will be needed for sidebar editing though

GreenReaper:
Huh, I guess I hit return at some point and submitted that comment early, whoops. ^^'
As you say, it might be desirable to allow others to edit the sidebar as well.

What I was going to say is that sitewide CSS _was_ useful - despite being pretty powerful, too. I needed it to add an icon in mobile mode and adjust the sidebar width. And I was able to edit the sidebar, too; on my wiki, at least, sysop has editinterface.

I thought this might have been added, but it's a default: https://github.com/wbstack/mediawiki/blob/main/includes/DefaultSettings.php#L5611 ...and from what I can see it's just interface-admin that's been removed, not that default privilege.

User CSS/JS do allow flexibility, but is that an issue if it's just for the user in question? Perhaps if it interacts poorly with site changes. Might also be a slight performance impact to include them. For some use-cases, a better approach might be gadgets (#47).

addshore:
Aaah yes admins seem to have:

Edit sitewide JSON (editsitejson)
Edit the user interface (editinterface)

editinterface used to allow editing JS, im not sure if that is still the case or if that is fully split into its own permission?

GreenReaper:
editsitejs was split off in T190015; so now, only interface-admin has all relevant rights by default; the first user is a member. Wikimedia requires 2FA, due to the risks.

It also means that MediaWiki:Copyright can't be edited, since it is in $wgRawHtmlMessages, though that does not appear to show up anyway - perhaps it will when it is possible to set a site copyright, or one is chosen, via $wgRightsText etc. Depending on the use to which WBStack's code is put, copyright control may or may not be delegated to the editing community; I suspect if anything it would be a 'crat or control panel option. Other core raw messages like Googlesearch are probably not as relevant. Extensions may add some, though.

Oddly WBStack users have editmyuserjsredirect, but I think this isn't useful without editmyuserjs to start with (edituserjs would override it, if we had it). Wikimedia revoked the former in hidden task [T207750; the title of which may be revealed in Wikitech server admin log for 2019-07-18. It was done in concert with T228374 - "Deploy SecureLinkFixer to beta cluster".]

Event Timeline

See also the somewhat-related T343686. Site JS/CSS is covered in T310787 and (more generally) T356397.

This comment was removed by GreenReaper.

MediaWiki:Sidebar in specific Wikibase Cloud instances can be edited, as far as I can see; e.g. I have edited the one in my instance, https://hypotheseis.wikibase.cloud/wiki/MediaWiki:Sidebar