Page MenuHomePhabricator

translatewiki export removed newly added message documentation in qqq.json
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT

Description

Since the automatic export for MediaWiki core/extension some exports removed newly added message documation in qqq.json:

Another case, the otherway;

Event Timeline

Nikerabbit triaged this task as High priority.EditedMar 7 2024, 12:10 PM
Nikerabbit subscribed.

For the first case, the messages had been added many hours earlier: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1008552. When did you process the message changes?

In the logs I see

[2024-03-07T07:03:27.696341+00:00] Translate.GroupSynchronization.INFO: Starting exports for groups core {"groups":"core"} []
[2024-03-07T07:07:56.425833+00:00] Translate.GroupSynchronization.INFO: [MediaWiki\Extension\Translate\Synchronization\ManageGroupsSpecialPage] Synchronization started for core by Raymond {"groupId":"core","user":"Raymond"} []
[2024-03-07T07:07:20.249306+00:00] Translate.GroupSynchronization.INFO: Finished export process for groups core. Time: 232.552 secs. {"groups":"core","duration":232.552} []
[2024-03-07T07:07:56.420290+00:00] Translate.GroupSynchronization.INFO: [MediaWiki\Extension\Translate\Synchronization\ManageGroupsSpecialPage] Synchronization started for ext-visualeditor-ve-mw by Raymond {"groupId":"ext-visualeditor-ve-mw","user":"Raymond"} []
[2024-03-07T07:07:56.425833+00:00] Translate.GroupSynchronization.INFO: [MediaWiki\Extension\Translate\Synchronization\ManageGroupsSpecialPage] Synchronization started for core by Raymond {"groupId":"core","user":"Raymond"} []
[2024-03-07T07:07:56.427536+00:00] Translate.GroupSynchronization.INFO: [MediaWiki\Extension\Translate\Synchronization\ManageGroupsSpecialPage] Synchronization started for mediawiki-api by Raymond {"groupId":"mediawiki-api","user":"Raymond"} []
[2024-03-07T07:14:50.273294+00:00] Translate.GroupSynchronization.INFO: Group synchronization is in progress [] []
[2024-03-07T07:14:50.282171+00:00] Translate.GroupSynchronization.INFO: All message groups are now in sync. [] []
[2024-03-07T07:14:50.296644+00:00] Translate.GroupSynchronization.INFO: Script completed successfully. 0 group synchronization(s) is/are in progress {"inProgressGroupCount":0} []
[2024-03-07T07:29:50.374943+00:00] Translate.GroupSynchronization.INFO: All message groups are in sync [] []

The export for core should not have started since changes for the group hadn't been processed yet.

Change 1009519 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Add debug logging to GroupSynchronizationCache

https://gerrit.wikimedia.org/r/1009519

Nikerabbit renamed this task from translatewiki export removed newly added message documation in qqq.json to translatewiki export removed newly added message documentation in qqq.json.Mar 7 2024, 12:56 PM
Nikerabbit set the point value for this task to 4.Mar 7 2024, 1:24 PM

We had a pair debugging session with Abijeet. We found a probably cause related to interaction of ImportExternalMessageChangesMaintenanceScript and ExternalMessageSourceStateImporter when the --safe-import parameter is not used.

Change 1009519 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add debug logging to GroupSynchronizationCache

https://gerrit.wikimedia.org/r/1009519

Change 1010673 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] GroupSyncCache: Mark group for review even if import strategy is none

https://gerrit.wikimedia.org/r/1010673

Change 1010675 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ImportExternalTranslation: Refactor group import and sync cache checks

https://gerrit.wikimedia.org/r/1010675

Change 1010673 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] GroupSyncCache: Mark group for review even if import strategy is none

https://gerrit.wikimedia.org/r/1010673

Nikerabbit updated Other Assignee, added: Nikerabbit.

Change 1010675 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ImportExternalTranslation: Refactor group import and sync cache checks

https://gerrit.wikimedia.org/r/1010675

The fixes for this have been deployed on translatewiki.net. Exports and imports are working as expected. There is no direct way to test this. We just shouldn't see this issue happening again.

@Raymond Please let us know if you still see this happening.