Page MenuHomePhabricator

Reply buttons disappear after replying once, until reloading the page
Closed, ResolvedPublicBUG REPORT

Description

Reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Reply_script_not_loading_properly?.

For few days now I've been having trouble with the reply button: after I reply to one comment, the reply button will disappear and I have to reload the page to see it. Quite annoying when I want to leave multiple comments on the same page. This happens in English and Polish Wikipedia, in differne browsers (Chrome and Edge), and in two accounts I checked (I've an authorized alt).

Event Timeline

This happens with [ reply ] links, but not the new reply buttons.

The problem is caused because we pass dtenable=1 to the API, which enables all DT features, including visual enhancements. In the past this wasn't a problem because we toggled buttons/links using CSS, but now we only generate the "correct" one.

I tried to remove dtenable=1 from all API requests in the past, so I think now is a good time to try again.

Change #1014096 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Pass through dtenable from main request query string

https://gerrit.wikimedia.org/r/1014096

Change #1014096 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Pass through dtenable from main request query string

https://gerrit.wikimedia.org/r/1014096

Ryasmeen claimed this task.
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Ryasmeen added a project: Verified.