Page MenuHomePhabricator

[BUG] Translatewiki app name translations are not added to app
Open, MediumPublic2 Estimated Story PointsBUG REPORT

Description

There are a few steps here:

1. We need to confirm that a Translatewiki change to CFBundleDisplayName (example here from zh-hans) will result in an update to the appropriate change in Wikipedia/Localizations/{langCode}.lproj/InfoPlist.strings file when a Translatewiki PR is opened. The last time one of these files was changed was 2017, so I suspect something is broken on the Translatewiki side to prevent this change. - This is fixed, see https://github.com/wikimedia/wikipedia-ios/pull/4807

  1. Once that's working, we need to be sure our import script appropriately applies those changes to the Wikipedia/iOS Native Localiations/{languageCode}.lproj/InfoPlist.strings file. We also need to be sure it applies to the fastlane/metadata/{langCode}/name.txt file. It seems like this is already a part of our import script (see here), but this flow hasn't been tested in forever.
  2. Once that's all in place, we need to add a step to our Xcode Cloud post-build script that uploads metadata via fastlane to App Store Connect. Note: This step has a related volunteer PR that should be merged or closed at the same time: T357323).

Event Timeline

Nikerabbit set the point value for this task to 2.
Nikerabbit subscribed.

If I remember correctly, this group name is missing from repoconfig.yaml.

I also proposed to do a full review that all defined groups are exported (Details in language engineering telegram channel).

Change #1017285 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] repoconfig.yaml: Add id for Wikipedia iOS Mobile metadata

https://gerrit.wikimedia.org/r/1017285

Change #1017291 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] repoconfig.yaml: Fix id for mediawiki installer

https://gerrit.wikimedia.org/r/1017291

I wrote a small script to compare the group ids in repconfig.yaml and the output of extensions/Translate/scripts/expand-groupspec.php '*' --exportable

Other than the out-wikimedia-mobile-wikipedia-ios-meta project I also found the mediawiki-installer project that's missing. Submitted patches to add both.

Change #1017285 merged by jenkins-bot:

[translatewiki@master] repoconfig.yaml: Add id for Wikipedia iOS Mobile metadata

https://gerrit.wikimedia.org/r/1017285

Change #1017291 merged by jenkins-bot:

[translatewiki@master] repoconfig.yaml: Fix id for mediawiki installer

https://gerrit.wikimedia.org/r/1017291

@Nikerabbit Thanks! Looks good to me. I think the rest of the fixes are client-side, so I will remove the language tags.

We need to get through our feature work but will have some bug fix time later. When we do we can revisit this ticket.

JTannerWMF lowered the priority of this task from High to Medium.Tue, Apr 16, 6:45 PM
JTannerWMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.